Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gc1Nz-0000ay-HP for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 05:05:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gc1Nx-0001Mk-T3 for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 05:05:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gc1Nx-0001ME-DH for pgsql-hackers@lists.postgresql.org; Wed, 26 Dec 2018 05:05:37 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gc1No-0002M0-TJ for pgsql-hackers@lists.postgresql.org; Wed, 26 Dec 2018 05:05:34 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wBQ55Rv9016574; Wed, 26 Dec 2018 14:05:27 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 4DDE9638B91; Wed, 26 Dec 2018 14:05:27 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 42943638B90; Wed, 26 Dec 2018 14:05:27 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.68]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 3E559400CCC; Wed, 26 Dec 2018 14:05:27 +0900 (JST) Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS References: <20181219052705.GD19856@paquier.xyz> <830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp> <20181219092255.GC680@paquier.xyz> <1c45ffd5-0a03-7608-43d8-a828253c0c52@lab.ntt.co.jp> <20181220013831.GJ27104@paquier.xyz> <9e5c22ec-6071-5495-0265-b7a96afb1a15@lab.ntt.co.jp> <20181221071300.GA1343@paquier.xyz> <5be2c21a-9a15-8200-0c76-6bc936ef69f7@lab.ntt.co.jp> <20181225052703.GE2334@paquier.xyz> From: Tatsuro Yamada Message-ID: <063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp> Date: Wed, 26 Dec 2018 14:05:19 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181225052703.GE2334@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Michael Paquier Cc: Kyotaro HORIGUCHI , pgsql-hackers@lists.postgresql.org X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2018/12/25 14:27, Michael Paquier wrote: > On Tue, Dec 25, 2018 at 10:56:04AM +0900, Tatsuro Yamada wrote: >> Hmm... Okey, I agree. Why I implemented the exotic part of the >> feature is that it is for user-friendly. However, I suppose that >> user know the syntax because the syntax is used by an expert user. > > Thanks, I have committed this one after making the logic to ignore > column numbers a bit smarter, one problem being that "ALTER INDEX foo > ALTER COLUMN" would try to suggest SET STATISTICS directly, which is > incorrect. Instead I have tweaked the completion so as COLUMN is > added after "ALTER INDEX foo ALTER". This could be completed later > with the column numbers, in a way similar to what ALTER TABLE does. > -- > Michael Thanks for taking your time! :) Cheers! Tatsuro Yamada