Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYETx-006N2u-Gj for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 01:15:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tYETw-002uc7-6Z for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 01:15:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYETv-002ubz-NV for pgsql-hackers@lists.postgresql.org; Thu, 16 Jan 2025 01:15:36 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYETt-000eSx-2U for pgsql-hackers@postgresql.org; Thu, 16 Jan 2025 01:15:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1736990132; bh=5l+8MQh1metmZesSUlJiXqtlRNZyRy/A8DYKTRmKoqQ=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=33/hXij6BfOl28oOi2HwxwR3aC1s23IIgqbaxElKu7EDqZzCN9uToFJc0D079rXC2 PnrWpMMK6cZqOhTPeELuYA165mamCOsElx2kdPX7CYDRRjM3Wezh+d5D1a0m9+kU9g C/ZcBtW0m/TCYd2Hb0cRJ0POQX4sFOhniUY2Enh6+hXjs7hsaNzv0ppj5R2WPwLuep NU9jz1SNZMU0touGWa/a4ZNYqWuTKuotK/+cF0iP9PT1DvLFEM+yOc7N4XQXVxQR1d HNZzLwARZXP2sLp+9CgaQm2VYoQphURphT2ln91qmssLp9Uy5lPgTCYw2dpO3baCxD C4Lntihp38UBg== Received: from [172.30.48.162] (unknown [172.30.48.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id C359360A07; Thu, 16 Jan 2025 04:15:31 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------72hjkhDtBqobD5vmJd0wb9WX" Message-ID: <0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru> Date: Thu, 16 Jan 2025 04:15:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Change GUC hashtable to use simplehash? To: John Naylor Cc: Jeff Davis , Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Tom Lane , Gurjeet Singh , pgsql-hackers@postgresql.org References: <09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com> <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> Content-Language: en-US From: "Anton A. Melnikov" In-Reply-To: X-KSMG-AntiPhishing: NotDetected, bases: 2025/01/16 00:08:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/01/15 23:40:00 #27037727 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------72hjkhDtBqobD5vmJd0wb9WX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, John! On 19.12.2024 12:48, John Naylor wrote: > That would actually be a maintenance headache because the function is > inlined, but here's a better idea: We already have a fallback path for > when the string is not suitably aligned, or in 32-bit builds. We could > just use that under Valgrind: > > static inline size_t > fasthash_accum_cstring(fasthash_state *hs, const char *str) > { > -#if SIZEOF_VOID_P >= 8 > +#if SIZEOF_VOID_P >= 8 && !defined(USE_VALGRIND) > > Any objections? This variant doesn't produce error and helped me to move further beyond initdb in the some tests under valgrind and fix a number of bugs. Thank you very much! Seems it is possible to exclude much less code from checking under valgrind and get the same result by replacing the only function call pg_rightmost_one_pos64() with a valgrind-safe code. See the attached patch, please. The pg_rightmost_one_pos64() itself can also be valgrind-safe in some cases when the last version of its code works. But i'm not sure if it's worth writing extra preprocessor instructions to make this small piece of code also checkable under valgrind. So in the patch i made a simple variant without it. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --------------72hjkhDtBqobD5vmJd0wb9WX Content-Type: text/x-patch; charset=UTF-8; name="v1-0001-Add-valgrind-safe-code-to-find-rightmost-bytes.patch" Content-Disposition: attachment; filename*0="v1-0001-Add-valgrind-safe-code-to-find-rightmost-bytes.patch" Content-Transfer-Encoding: base64 RnJvbSA3YWYwNTcwM2U1OWZiOGYxZTUxZWMxZDY2N2RkYzE1MGM0MDc1NmYwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW50b24gQS4gTWVsbmlrb3YiIDxhLm1lbG5pa292 QHBvc3RncmVzcHJvLnJ1PgpEYXRlOiBUaHUsIDE2IEphbiAyMDI1IDAyOjU2OjUyICswMzAw ClN1YmplY3Q6IFtQQVRDSF0gQWRkIHZhbGdyaW5kLXNhZmUgY29kZSB0byBmaW5kIGEgbnVt YmVyIG9mIHJpZ2h0bW9zdCB6ZXJvCiBieXRlcy4KCi0tLQogc3JjL2luY2x1ZGUvY29tbW9u L2hhc2hmbl91bnN0YWJsZS5oIHwgMTEgKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1 ZGUvY29tbW9uL2hhc2hmbl91bnN0YWJsZS5oIGIvc3JjL2luY2x1ZGUvY29tbW9uL2hhc2hm bl91bnN0YWJsZS5oCmluZGV4IGEwOWMwYjdkNWNlLi43Njc0YzM5YjFjYSAxMDA2NDQKLS0t IGEvc3JjL2luY2x1ZGUvY29tbW9uL2hhc2hmbl91bnN0YWJsZS5oCisrKyBiL3NyYy9pbmNs dWRlL2NvbW1vbi9oYXNoZm5fdW5zdGFibGUuaApAQCAtMzAyLDEzICszMDIsMjIgQEAgZmFz dGhhc2hfYWNjdW1fY3N0cmluZ19hbGlnbmVkKGZhc3RoYXNoX3N0YXRlICpocywgY29uc3Qg Y2hhciAqc3RyKQogCQlzaXplX3QJCXJlbWFpbmRlcjsKIAkJdWludDY0CQltYXNrOwogCisj aWYgIWRlZmluZWQoVVNFX1ZBTEdSSU5EKQogCQkvKgogCQkgKiBUaGUgYnl0ZSBjb3JyZXNw b25kaW5nIHRvIHRoZSBOVUwgd2lsbCBiZSAweDgwLCBzbyB0aGUgcmlnaHRtb3N0CiAJCSAq IGJpdCBwb3NpdGlvbiB3aWxsIGJlIGluIHRoZSByYW5nZSAxNSwgMjMsIC4uLiwgNjMuIFR1 cm4gdGhpcyBpbnRvCiAJCSAqIGJ5dGUgcG9zaXRpb24gYnkgZGl2aWRpbmcgYnkgOC4KIAkJ ICovCiAJCXJlbWFpbmRlciA9IHBnX3JpZ2h0bW9zdF9vbmVfcG9zNjQoemVyb19ieXRlX2xv dykgLyBCSVRTX1BFUl9CWVRFOwotCisjZWxzZQorCQkvKiB2YWxncmluZC1zYWZlIHZhcmlh bnQgKi8KKwkJcmVtYWluZGVyID0gMDsKKwkJd2hpbGUgKCh6ZXJvX2J5dGVfbG93ICYgMHhG RikgPT0gMCkKKwkJeworCQkJemVyb19ieXRlX2xvdyA+Pj0gODsKKwkJCSsrcmVtYWluZGVy OworCQl9CisjZW5kaWYKIAkJLyoKIAkJICogQ3JlYXRlIGEgbWFzayBmb3IgdGhlIHJlbWFp bmluZyBieXRlcyBzbyB3ZSBjYW4gY29tYmluZSB0aGVtIGludG8KIAkJICogdGhlIGhhc2gu IFRoaXMgbXVzdCBoYXZlIHRoZSBzYW1lIHJlc3VsdCBhcyBtaXhpbmcgdGhlIHJlbWFpbmlu ZwotLSAKMi40OC4xCgo= --------------72hjkhDtBqobD5vmJd0wb9WX--