Date: Thu, 6 Feb 2025 20:13:47 +0800
From: Zhang Mingli <zmlpostgres@gmail.com>
To: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Message-ID: <0663eec9-883d-4c25-ade4-58f227ece827@Spark>
In-Reply-To: <202502061031.wlj7ysbk7rfi@alvherre.pgsql>
References: <202502061031.wlj7ysbk7rfi@alvherre.pgsql>
Subject: Re: Proposal to CREATE FOREIGN TABLE LIKE
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="67a4a780_5108445b_1738b"
Archived-At: <https://www.postgresql.org/message-id/0663eec9-883d-4c25-ade4-58f227ece827%40Spark>
Precedence: bulk

--67a4a780_5108445b_1738b
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On =46eb 6, 2025 at 18:31 +0800, =C3=81lvaro Herrera <alvherre=40alvh.no-=
ip.org>, wrote:
>
> Ah, but our fine manual already says
>
> The LIKE clause can also be used to copy column definitions from views,=

> foreign tables, or composite types. Inapplicable options (e.g.,
> INCLUDING INDEXES from a view) are ignored.
>
> so what you implemented seems to be okay from that POV.
Hi, Yeah,

Our current convention is to ignore any inapplicable options without thro=
wing errors.

As you mentioned, we use bits to identify the options, which does add som=
e complexity to the codes if we try to track the origin of the option bit=
s.

--
Zhang Mingli
HashData

--67a4a780_5108445b_1738b
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<html xmlns=3D=22http://www.w3.org/1999/xhtml=22>
<head>
<title></title>
</head>
<body>
<div name=3D=22messageReplySection=22>
<div dir=3D=22auto=22>On =46eb 6, 2025 at 18:31 +0800, =C3=81lvaro Herrer=
a &lt;alvherre=40alvh.no-ip.org&gt;, wrote:</div>
<blockquote style=3D=22border-left-color: rgb(26, 188, 156); margin: 5px;=
 padding-left: 10px; border-left-width: thin; border-left-style: solid;=22=
><br />
Ah, but our fine manual already says<br />
<br />
The LIKE clause can also be used to copy column definitions from views,<b=
r />
foreign tables, or composite types. Inapplicable options (e.g.,<br />
INCLUDING INDEXES from a view) are ignored.<br />
<br />
so what you implemented seems to be okay from that POV.</blockquote>
<div dir=3D=22auto=22>Hi, Yeah,<br />
<br />
Our current convention is to ignore any inapplicable options without thro=
wing errors.<br />
<br />
As you mentioned, we use bits to identify the options, which does add som=
e complexity to the codes if we try to track the origin of the option bit=
s.<br />
<br />
--<br />
Zhang Mingli<br />
HashData</div>
</div>
</body>
</html>

--67a4a780_5108445b_1738b--