Feedback-ID: ie0a040ee:Fastmail
Message-ID: <06b44ab0-8079-4f03-8d67-e7d2c9a9dad9@eisentraut.org>
Date: Tue, 23 Jul 2024 10:37:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Document use of ldapurl with LDAP simple bind
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <CAOYmi+nyg9gE0LeP=xQ3AgyQGR=5ZZMkVVbWd0uR8XQmg_dd5Q@mail.gmail.com>
 <99058de4-bf2a-497a-91a3-537228ad143f@eisentraut.org>
 <CAOYmi+m1xrWwGyOUPopQvYgOyPJa+TYAq3uZ09MmgkZq6RmCKA@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAOYmi+m1xrWwGyOUPopQvYgOyPJa+TYAq3uZ09MmgkZq6RmCKA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/06b44ab0-8079-4f03-8d67-e7d2c9a9dad9%40eisentraut.org>
Precedence: bulk

On 08.07.24 23:27, Jacob Champion wrote:
> On Fri, Jun 28, 2024 at 12:11 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> This appears to imply that specifying ldapurl is only applicable for
>> search+bind.  Maybe that whole message should be simplified to something
>> like
>>
>> "configuration mixes arguments for simple bind and search+bind"
>>
>> (The old wording also ignores that the error might arise via "ldapsuffix".)
> 
> I kept the imperative "cannot" and tried to match the terminology with
> our documentation at [1]:
> 
>      cannot mix options for simple bind and search+bind modes

Committed.

(I suppose this could be considered a bug fix, but I don't feel an 
urgency to go backpatching this.  Let me know if there are different 
opinions.)