Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j8lC4-0007e4-K2 for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Mar 2020 13:33:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j8lC3-0000Xa-4R for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Mar 2020 13:33:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j8lC2-0000XT-Rb for pgsql-hackers@lists.postgresql.org; Mon, 02 Mar 2020 13:33:10 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8lC0-00071S-Ac for pgsql-hackers@postgresql.org; Mon, 02 Mar 2020 13:33:10 +0000 Received: from Davids-MacBook-Pro.local (c-68-33-74-28.hsd1.md.comcast.net [68.33.74.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 7653A54670; Mon, 2 Mar 2020 13:33:05 +0000 (UTC) Subject: Re: Psql patch to show access methods info To: Alexander Korotkov Cc: Alvaro Herrera , Michael Paquier , Andres Freund , Nikita Glukhov , Thomas Munro , pgsql-hackers , Kyotaro HORIGUCHI References: <20200121223726.GA6714@alvherre.pgsql> From: David Steele Message-ID: <06e73feb-7ccf-a5ef-0843-79183ea30492@pgmasters.net> Date: Mon, 2 Mar 2020 08:33:04 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200121223726.GA6714@alvherre.pgsql> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Alexander, On 1/21/20 5:37 PM, Alvaro Herrera wrote: > On 2020-Jan-21, Alvaro Herrera wrote: > >> c) it would be damn handy if \dAf (maybe \dAf+) lists the datatypes that >> each opfamily has opclasses for. Maybe make the output an array, like >> {int4,int8,numeric,...} Something like [*] but somehow make it >> prettier? > > Sorry, I forgot to copy-edit my text here: I said "make it prettier", > but the query I submitted is already pretty enough ISTM; I had written > that comment when I only had the array_agg() version, but then I changed > it to string_agg() and that seems to have mostly done the trick. Maybe > improve the format_type() bit to omit the quotes, if possible, but that > doesn't seem a big deal. The last CF for PG13 has now started. Do you know when you'll be able to supply a new patch to address Álvaro's review? Regards, -- -David david@pgmasters.net