Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfPu7-00HZ2X-0R for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 19:47:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rfPu4-00EbpE-DS for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 19:47:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfPu3-00Ebp6-Vf for pgsql-hackers@lists.postgresql.org; Wed, 28 Feb 2024 19:47:44 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfPu1-001r0A-9p for pgsql-hackers@postgresql.org; Wed, 28 Feb 2024 19:47:43 +0000 Received: from [172.20.6.221] (unknown [178.134.136.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4TlPyb50k8z49Q10; Wed, 28 Feb 2024 21:47:35 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1709149658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8nlEnhfJTNydEosBGvJ3wK4gMzYawxINmceQZ5ZXoY=; b=QjVN6Oop9cWgeb1L+Z1jFu5IhogpHnNHIJ90uO7gmBgeXkAjc1ufYsJH9Qpfq6BZwEkCX6 a3VKj0auD4D2dvWqH48jHMDNBFK7URbl8Yp7AcMghyJiT1ys1sl2+kd9mpzQit73X3dKjp CR7Dwhg/Is3csZE9zVqnmVZNeFlx5KUjfl0lbtjPs3wGtG5GkxaeC6VFtQ7NQYxo9/dr68 HyJnW45xQDDDAjYE8TEcRkSGX2oworKK6+UeQdC0ZhwtsI3iIqYLVpxxl2uz0bO/NAWHep lkuVbhFFQcbHtOgJEpPHP9Xoh1+N0oEkORbT1DXk8X0jtdtEP/eZDvfQr6gVAw== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1709149658; a=rsa-sha256; cv=none; b=BcOWUoGVA2ujzU3PaAUU3eaM+gCwPkeKL749tmmCExy2F5f9W/mQoaRdFv773wT1eSdT4Y lvynrTDGQr88IRQnBgAs42i8MhKicvl2QymKqEBSsboO6MZmWpiyjXhYMlptpvfQMdurRv ME1xswduo5K3kgx5kutk14RbCWbRCkqnH34T3MFfyj/zAenIvnVjnN5sI/IDH52csy6B80 LC+s1pkF3/5Z37+FjxETTxbD5xVvHZeQXNvHFB7JbERkwE/upvML1+sSM6dtFvdlc27oH9 DGu/hHKwAENhNUAf7EY/NRLFox+1fuO2IeYa8f8fXq6bZdSAZpby4QlrJTU4og== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1709149658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M8nlEnhfJTNydEosBGvJ3wK4gMzYawxINmceQZ5ZXoY=; b=lJC+YUzx8FE031e8yoYSyZNGGB27QRaWw0+MKTZZxPr/JtnYhbWzB12ktmZzkuRLplCbMa CnYaKxfLrjlzj0Xeu2FXXbrV125AFFeMlUqMKskyf16sreEduNISlB66U6vC3p7kOZYumt v4gKaZ3SHQEBmOaWuTgB+Rp92RO4Ai4mJdTOXV6Fcnq6EOtznPmYF2RJNhNzNH+P9ZOn5w ikYdMHeGse7c1qhtv/bJvavTe2MesDqP1aa1HW2w5Fni9yFXyNbOf9jJZ25/iOm5VGJiyY tfT+1qAPlYsAXdhmLAfQROBXFikQr591SmYj1pLw4mIkWTQ0s4UfWXX6dryRbw== Message-ID: <07b5f917-f07a-4878-8c01-be491948da24@iki.fi> Date: Wed, 28 Feb 2024 23:47:33 +0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Relation bulk write facility Content-Language: en-US To: Tom Lane Cc: Andres Freund , Thomas Munro , Noah Misch , Michael Paquier , Robert Haas , Peter Smith , vignesh C , pgsql-hackers , Melanie Plageman References: <20240224212936.f3zcbs24f7oaapm4@alap3.anarazel.de> <0C469A7A-548C-4B0C-9495-730FE80046E1@iki.fi> <31db8d41-2ac9-4b5e-b7a8-712d6d7d7aa2@iki.fi> <20240225194322.a5@rfd.leadboat.com> <1535845.1708890691@sss.pgh.pa.us> <3a0d22fa-7613-4881-aa19-ddd31fb92cc0@iki.fi> <20240228092642.i23w4qzdsuy6da6y@alap3.anarazel.de> <2311406.1709136283@sss.pgh.pa.us> From: Heikki Linnakangas In-Reply-To: <2311406.1709136283@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 28/02/2024 18:04, Tom Lane wrote: > Heikki Linnakangas writes: >> On 28/02/2024 00:30, Thomas Munro wrote: >>> I agree, this should be an error, and we should then remove the test. > >> Done. > > The commit that added that test added a support function > "get_columns_length" which is now unused. Should we get rid of that > as well? I see you just removed it; thanks! -- Heikki Linnakangas Neon (https://neon.tech)