Subject: Re: language cleanups in code and docs
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
References: <20200708211756.GA23569@alvherre.pgsql>
From: David Steele <david@pgmasters.net>
Message-ID: <07e68696-7b45-37cc-4e36-4f682c80cb09@pgmasters.net>
Date: Wed, 8 Jul 2020 17:19:41 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200708211756.GA23569@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/8/20 5:17 PM, Alvaro Herrera wrote:
> On 2020-Jul-08, David Steele wrote:
> 
>> On 7/8/20 4:39 PM, Andres Freund wrote:
> 
>> I think this phrasing in the original/updated version is pretty awkward:
>>
>> +  A standby server that cannot be connected to until it is promoted to a
>> +  primary server is called a ...
> 
> Yeah.
> 
>> How about:
>>
>> + A standby server that must be promoted to a primary server before
>> + accepting connections is called a ...
> 
> How about just reducing it to "A standby server that doesn't accept
> connection is called a ..."?  We don't really need to explain that if
> you do promote the standby it will start accept connections -- do we?
> It should be pretty obvious if you promote a standby, it will cease to
> be a standby in the first place.  This verbiage seems excessive.

Works for me.

Regards,
-- 
-David
david@pgmasters.net