From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_38390E7B-ABC9-484E-9D64-60943944913A"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Quoting filename in using facing log messages
Message-Id: <080EEABE-6645-4A46-AB20-6285ADAC44FE@yesql.se>
Date: Wed, 13 Sep 2023 13:48:12 +0200
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Archived-At: <https://www.postgresql.org/message-id/080EEABE-6645-4A46-AB20-6285ADAC44FE%40yesql.se>
Precedence: bulk


--Apple-Mail=_38390E7B-ABC9-484E-9D64-60943944913A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Looking at ZQFUGOuS5DU4DsE4@paquier.xyz I noticed that we had a a few =
instances
of filenames in userfacing log messages (ie not elog or DEBUGx etc) not =
being
quoted, where the vast majority are quoted like \"%s\".  Any reason not =
to
quote them as per the attached to be consistent across all log messages?

--
Daniel Gustafsson


--Apple-Mail=_38390E7B-ABC9-484E-9D64-60943944913A
Content-Disposition: attachment;
	filename=quote_file_errmsg.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="quote_file_errmsg.diff"
Content-Transfer-Encoding: 7bit

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index f6f8adc72a..50cd165289 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -2248,7 +2248,7 @@ XLogWrite(XLogwrtRqst WriteRqst, TimeLineID tli, bool flexible)
 					errno = save_errno;
 					ereport(PANIC,
 							(errcode_for_file_access(),
-							 errmsg("could not write to log file %s "
+							 errmsg("could not write to log file \"%s\" "
 									"at offset %u, length %zu: %m",
 									xlogfname, startoffset, nleft)));
 				}
diff --git a/src/bin/pg_waldump/pg_waldump.c b/src/bin/pg_waldump/pg_waldump.c
index b9acfed3b7..a3535bdfa9 100644
--- a/src/bin/pg_waldump/pg_waldump.c
+++ b/src/bin/pg_waldump/pg_waldump.c
@@ -418,11 +418,11 @@ WALDumpReadPage(XLogReaderState *state, XLogRecPtr targetPagePtr, int reqLen,
 		if (errinfo.wre_errno != 0)
 		{
 			errno = errinfo.wre_errno;
-			pg_fatal("could not read from file %s, offset %d: %m",
+			pg_fatal("could not read from file \"%s\", offset %d: %m",
 					 fname, errinfo.wre_off);
 		}
 		else
-			pg_fatal("could not read from file %s, offset %d: read %d of %d",
+			pg_fatal("could not read from file \"%s\", offset %d: read %d of %d",
 					 fname, errinfo.wre_off, errinfo.wre_read,
 					 errinfo.wre_req);
 	}

--Apple-Mail=_38390E7B-ABC9-484E-9D64-60943944913A--