Message-ID: <081073df-32ff-498c-abeb-2e5590888ad9@joeconway.com>
Date: Tue, 28 Oct 2025 17:47:34 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Joe Conway <mail@joeconway.com>
Subject: Re: contrib/sepgsql regression tests have been broken for months
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
References: <1613232.1761255361@sss.pgh.pa.us>
 <2e327a21-9954-4d05-aa9e-3b7fe926f39f@joeconway.com>
 <371f0ee1-8507-46e0-9090-6df2b14f0cd8@joeconway.com>
Content-Language: en-US
In-Reply-To: <371f0ee1-8507-46e0-9090-6df2b14f0cd8@joeconway.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/081073df-32ff-498c-abeb-2e5590888ad9%40joeconway.com>
Precedence: bulk

On 10/24/25 08:28, Joe Conway wrote:
> On 10/24/25 07:49, Joe Conway wrote:
>> On 10/24/25 17:36, Tom Lane wrote:
>>> Anyway, we seem to need the attached in v18 and HEAD,
>>> and we really ought to get BF coverage going again.
>> 
>> I will make those changes (and hope nothing breaks).
> 
> And of course they did break :-(
> 
> Rhino is still running on RHEL 7.9 and it seems that needed perl RPMs are no
> longer in the yum repo. I will need some time to sort it out, but am on the road
> through the weekend, so it might be until sometime next week when I get enough
> 'round tuits' to get it resolved.

I predicted complaints about desupporting openssl < 1.1.1, just did not 
anticipate they would be from me ;-P

https://www.postgresql.org/message-id/flat/9a9a43e7-f1b7-4d77-b3df-9138ecfc6f6b%40joeconway.com#278b38135345257044aa1cd41b8dda83

Since 18+ requires openssl 1.1.1+ and CentOS 7.9 has openssl 1.0.2, and 
rhino is still on CentOS 7.9, rhino does not build with openssl.

However, with the tap tests enabled now, I am seeing this:

cat ./build-farm-root/HEAD/rhinoceros.lastrun-logs/configure.log
8<--------
...
with_selinux='yes'
with_ssl='no'
with_system_tzdata=''
...
8<--------

and in src/test/modules/Makefile:

8<--------
...
ifeq ($(with_ssl),openssl)
SUBDIRS += ssl_passphrase_callback
else
ALWAYS_SUBDIRS += ssl_passphrase_callbackssl_passphrase_callback
endif
8<--------

yet:

8<--------
./run_build.pl --nosend --nostatus --verbose --force --keepall
Tue Oct 28 13:47:01 2025: buildfarm run for rhinoceros:HEAD starting
rhinoceros:HEAD          [13:47:01] checking out source ...
...
rhinoceros:HEAD          [13:55:00] running bin checks ...
rhinoceros:HEAD          [14:08:09] running make misc checks ...
Branch: HEAD
Stage ssl_passphrase_callbackCheck failed with status 2
8<--------

and:

8<--------
tail -n23 
/opt/src/pgsql-git/build-farm-root/HEAD/pgsql.build/tmp_install/log/install.log|head 
-n3
ccache gcc -std=gnu11 -Wall -Wmissing-prototypes -Wpointer-arith 
-Wdeclaration-after-statement -Werror=vla -Wendif-labels 
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing 
-fwrapv -fexcess-precision=standard -g -O2 -fPIC -fvisibility=hidden -I. 
-I. -I../../../../src/include -D_GNU_SOURCE  -I/usr/include/libxml2 
-c -o ssl_passphrase_func.o ssl_passphrase_func.c
ssl_passphrase_func.c:29:23: error: unknown type name ‘SSL_CTX’
  static void set_rot13(SSL_CTX *context, bool isServerStart);
8<--------

I am not understanding why ssl_passphrase_callbackCheck is being run at 
all, but that is currently where I am stuck ¯\_(ツ)_/¯.

For the moment I have disabled the cron job on rhino. I guess I need to 
up the urgency on getting the OS upgraded to something supported...

-- 
Joe Conway
PostgreSQL Contributors Team
Amazon Web Services: https://aws.amazon.com