Content-Type: multipart/mixed; boundary="------------UdoPnlTJ0T7MIgbyecXzCT0i"
Message-ID: <08129593-6f3c-4fb9-94b7-5aa2eefb99b0@oss.nttdata.com>
Date: Wed, 25 Jun 2025 00:26:12 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-hackers@lists.postgresql.org
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: pg_dumpall dumps global objects with --statistics-only or --no-schema
Archived-At: 
 <https://www.postgresql.org/message-id/08129593-6f3c-4fb9-94b7-5aa2eefb99b0%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------UdoPnlTJ0T7MIgbyecXzCT0i
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

While testing pg_dumpall in v18, I noticed that it still dumps global objects
such as roles and tablespaces even when --statistics-only or --no-schema is
specified. This seems unexpected.

Since pg_dumpall treats global objects as schema-level content, it currently
includes them with --schema-only but skips them with --data-only. By that logic,
it should also skip them when either --statistics-only or --no-schema is used.
Thought?

Attached is a patch to fix this behavior.

Originally, I planned to work on this after we settled the ongoing discussion
about pg_dump options in [1], but since that may take some time, I wanted to
bring this up now so I don't forget the issue.

Regards,

[1] https://postgr.es/m/7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org

-- 
Fujii Masao
NTT DATA Japan Corporation

--------------UdoPnlTJ0T7MIgbyecXzCT0i
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-pg_dumpall-Skip-global-objects-with-statistics-on.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-pg_dumpall-Skip-global-objects-with-statistics-on.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBhM2NkN2M3NmY0NTYxNDRjNjJlMzY1MmNmM2VkZDc3ZDJkOGQzODE2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFR1ZSwgMjQgSnVuIDIwMjUgMjM6NTY6MjggKzA5MDAKU3ViamVjdDogW1BB
VENIIHYxXSBwZ19kdW1wYWxsOiBTa2lwIGdsb2JhbCBvYmplY3RzIHdpdGggLS1zdGF0aXN0
aWNzLW9ubHkgb3IKIC0tbm8tc2NoZW1hLgoKUHJldmlvdXNseSwgcGdfZHVtcGFsbCB3b3Vs
ZCBzdGlsbCBkdW1wIGdsb2JhbCBvYmplY3RzIHN1Y2ggYXMgcm9sZXMKYW5kIHRhYmxlc3Bh
Y2VzIGV2ZW4gd2hlbiAtLXN0YXRpc3RpY3Mtb25seSBvciAtLW5vLXNjaGVtYSB3YXMgc3Bl
Y2lmaWVkLgpTaW5jZSB0aGVzZSBnbG9iYWwgb2JqZWN0cyBhcmUgdHJlYXRlZCBhcyBzY2hl
bWEtbGV2ZWwgZGF0YSwgdGhleSBzaG91bGQKYmUgc2tpcHBlZCBpbiB0aGVzZSBjYXNlcy4K
ClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpc3N1ZSBieSBlbnN1cmluZyB0aGF0IGdsb2JhbCBv
YmplY3RzIGFyZSBub3QKZHVtcGVkIHdoZW4gZWl0aGVyIC0tc3RhdGlzdGljcy1vbmx5IG9y
IC0tbm8tc2NoZW1hIGlzIHVzZWQuCi0tLQogc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwu
YyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt
KQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wYWxsLmMgYi9zcmMvYmlu
L3BnX2R1bXAvcGdfZHVtcGFsbC5jCmluZGV4IDNjYmNhZDY1YzVmLi4xMDAzMTdiMWFhOSAx
MDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwuYworKysgYi9zcmMvYmlu
L3BnX2R1bXAvcGdfZHVtcGFsbC5jCkBAIC02MzIsNyArNjMyLDcgQEAgbWFpbihpbnQgYXJn
YywgY2hhciAqYXJndltdKQogCQlmcHJpbnRmKE9QRiwgIlNFVCBlc2NhcGVfc3RyaW5nX3dh
cm5pbmcgPSBvZmY7XG4iKTsKIAlmcHJpbnRmKE9QRiwgIlxuIik7CiAKLQlpZiAoIWRhdGFf
b25seSkKKwlpZiAoIWRhdGFfb25seSAmJiAhc3RhdGlzdGljc19vbmx5ICYmICFub19zY2hl
bWEpCiAJewogCQkvKgogCQkgKiBJZiBhc2tlZCB0byAtLWNsZWFuLCBkbyB0aGF0IGZpcnN0
LiAgV2UgY2FuIGF2b2lkIGRldGFpbGVkCi0tIAoyLjQ5LjAKCg==

--------------UdoPnlTJ0T7MIgbyecXzCT0i--