Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khRRU-0008IF-7i for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Nov 2020 06:04:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1khRRS-0003r7-3D for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Nov 2020 06:04:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khRRR-0003qw-NP for pgsql-hackers@lists.postgresql.org; Tue, 24 Nov 2020 06:04:41 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1khRRJ-0006Ko-JW for pgsql-hackers@postgresql.org; Tue, 24 Nov 2020 06:04:40 +0000 Received: from [192.168.28.94] (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id A4E2321C50E7; Tue, 24 Nov 2020 09:04:29 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1606197870; bh=xUNz+2tgYaGmqljpLtT6s5K/Mlm7my5zAmu89EbjYC8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=YBkRBOh22Uko+Wr16KUbdtdNOKBzTfrgQ3A0qwOL7bGgl60kXhgw3C/Nyj2ZL88vK sTjTzyVI71JWUWnGXbKRaGpzjx9IlYVyZutUAlKr6r8t1/PjemvABpc3pBr0D+iyv5 uhJ0uKL65+Qe0w7Qe9tC8Aqd6rwBCij+Zs8aCvCE= Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions To: "tsunakawa.takay@fujitsu.com" , 'Etsuro Fujita' Cc: Tomas Vondra , Amit Langote , Alexey Kondratov , Michael Paquier , Ashutosh Bapat , Ashutosh Bapat , PostgreSQL-Dev References: <27e119ab-70a4-a08a-deb2-d882e2ce9435@postgrespro.ru> <21741c8e5df397d88e9eff3e741baf91@postgrespro.ru> <2a33a068-749c-4c18-ba74-bd6fbf37abce@postgrespro.ru> <8ddacbf0-d489-cd56-fecc-e09a7e02a7c1@postgrespro.ru> <4a40adce-4f52-7ddc-b45c-0bea13f1cce0@enterprisedb.com> From: Andrey Lepikhov Organization: Postgres Professional Message-ID: <08254e4c-0f77-f1b7-cbba-7c41018b3f10@postgrespro.ru> Date: Tue, 24 Nov 2020 11:04:27 +0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 11/24/20 9:27 AM, tsunakawa.takay@fujitsu.com wrote: > Andrey-san, Fujita-san, > > From: Etsuro Fujita >> On Mon, Nov 23, 2020 at 5:39 PM Andrey Lepikhov >> wrote: >>> On 11/23/20 7:49 AM, tsunakawa.takay@fujitsu.com wrote: >>>> Could I or my colleague continue this patch in a few days? It looks it's >> stalled over one month. >>> >>> I don't found any problems with this patch that needed to be corrected. >>> It is wait for actions from committers side, i think. >> >> I'm planning to review this patch. I think it would be better for >> another pair of eyes to take a look at it, though. > > > There are the following two issues left untouched. > > https://www.postgresql.org/message-id/TYAPR01MB2990DC396B338C98F27C8ED3FE1F0%40TYAPR01MB2990.jpnprd01.prod.outlook.com I disagree with your opinion about changing the interface of the ExecRelationAllowsMultiInsert routine. If you insist on the need for this change, we need another opinion. -- regards, Andrey Lepikhov Postgres Professional