Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puBPw-0005or-6l for pgsql-hackers@arkaria.postgresql.org; Wed, 03 May 2023 12:17:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1puBPt-0008OF-Gr for pgsql-hackers@arkaria.postgresql.org; Wed, 03 May 2023 12:17:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puBPt-0008LS-88 for pgsql-hackers@lists.postgresql.org; Wed, 03 May 2023 12:17:05 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1puBPm-000Iew-Eu for pgsql-hackers@lists.postgresql.org; Wed, 03 May 2023 12:17:04 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f3331f928cso31801115e9.2 for ; Wed, 03 May 2023 05:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683116216; x=1685708216; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=seLziNojhaSL87xivV1D+dFnXPujw2skg426S4Wr4Yo=; b=f/72WpwIEIqc1FuxCVTR5HKOB0+gtC+bHoZ5igTfR/Ws/WAL3Ug/7LZzRFCPE1a1lE ceRB+LFhHSB24vFFKrhSc/f7iSyBlfymIYmSdwQZ24HU9XyeSyHRTycOrzJm4sfJxgc7 bFAancFG2/qvUvxVpzIPNzdvyUn6i67jpjp8/C43nIVFoQ+F0F5JF9clNZsT0lrSZplh LTisLnfJRmvHcbacZIZh26Dik1KlNCMInlVpWWlRZiimSt2dVE3R2UO0+/D4Ysy/hG6E wKfV7GVRlchH62szcvNLqHmFNCKPaH8qAbQMECtdRsaweWFrMvRgEzOcDrD8nMV3OPde tz3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683116216; x=1685708216; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=seLziNojhaSL87xivV1D+dFnXPujw2skg426S4Wr4Yo=; b=WtgVx/HEaPAc7hwUOiHvaZjIWQqMqSanryda42SoK6e9wncvD0zgM636iYcY0MxEXl 0JXt63UO+lf3W5fanqf5g1NPAnRaIonTQwhjBfS+JhIP9cjNl6Lr/n5CW3lbUopJVV5i lCQMp+tBYqjQeySSXr6u1akW3B+qW+HX49BWdZK4ZKlvoekae8eq4uUorEIi3PRckbbv VtBghUmXbqbYLr23hMx1+DIpKbmnG7H5OseupvVrkHNbN3uMR7ERv7dqo+WTkQfxXsvT 3xn6nXevNOlcJsSPlm45hZGrUyxoGxrbncSrJDdSpXAqEljkJr83GQtW3u9GUwmi2fFb aijw== X-Gm-Message-State: AC+VfDwpEVqT+Oz3Qjb3QoH8rSH+BqOhBh8E+GE1o48ISKxRCbQXo6gr VZrmZeNtGjxv0jxaHqLCU3o= X-Google-Smtp-Source: ACHHUZ4JjYtlMyPjzpIf3jJ8d587FUUv9m6rEDBELosbBVV3mBAfx02ZwZ7o+MJbNChCvArzDSy8Rg== X-Received: by 2002:a7b:cc88:0:b0:3f1:73c5:66db with SMTP id p8-20020a7bcc88000000b003f173c566dbmr14175094wma.20.1683116216411; Wed, 03 May 2023 05:16:56 -0700 (PDT) Received: from [192.168.10.194] ([54.239.6.188]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c204100b003ed2c0a0f37sm1741761wmg.35.2023.05.03.05.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 May 2023 05:16:55 -0700 (PDT) Message-ID: <083247ee-2366-dd53-803b-0582faa6a52a@gmail.com> Date: Wed, 3 May 2023 14:16:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl To: Amit Kapila Cc: "Yu Shi (Fujitsu)" , vignesh C , PostgreSQL Hackers References: <2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com> <9ab1827c-9a57-8c48-59b2-c5fb62c21be3@gmail.com> <74f80bc1-6b39-b2a8-c716-98beefb75e0b@gmail.com> <17b6b056-4f53-c444-0c94-869547d1a5df@gmail.com> <054defef-de15-53e4-6c5a-d16ccc21d4ba@gmail.com> <8a13f0d8-71f3-773b-7135-5974fd53724b@gmail.com> Content-Language: en-US From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 5/3/23 12:29 PM, Amit Kapila wrote: > On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand > wrote: >> >> >> As per your suggestion, changing the insert ordering (like in V8 attached) makes it now work on the failing environment too. >> > > I think it is better to use wait_for_replay_catchup() to wait for > standby to catch up. Oh right, that's a discussion we already had in [1], I should have thought about it. > I have changed that and a comment in the > attached. I'll push this tomorrow unless there are further comments. > LGTM, thanks! [1]: https://www.postgresql.org/message-id/acbac69e-9ae8-c546-3216-8ecb38e7a93d%40gmail.com Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com