Message-ID: <08507458-8222-483c-9234-150d1a607efe@iki.fi>
Date: Mon, 28 Oct 2024 18:52:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Avoid possible overflow (src/port/bsearch_arg.c)
To: Tomas Vondra <tomas@vondra.me>, Ranier Vilela <ranier.vf@gmail.com>,
 Nathan Bossart <nathandbossart@gmail.com>, Tomas Vondra <tv@fuzzy.cz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
References: <CAEudQAp34o_8u6sGSVraLwuMv9F7T9hyHpePXHmRaxR2Aboi+w@mail.gmail.com>
 <ZwWkBb2gxs5fGttK@nathan>
 <CAEudQAr8KZET1ogPnT7esb7YdYbmJyFZWo-OnP+FgoKeL+N31A@mail.gmail.com>
 <b316ad5b-6c94-4f23-8d24-57ec4a430c10@iki.fi>
 <54ee5b1f-bf75-48ea-b642-1ef275c1a093@vondra.me>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <54ee5b1f-bf75-48ea-b642-1ef275c1a093@vondra.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/08507458-8222-483c-9234-150d1a607efe%40iki.fi>
Precedence: bulk

On 28/10/2024 17:30, Tomas Vondra wrote:
>> Some of those other implementations have fixed this, others have not.
>> And they all seem to also have the "involes" typo in the comment that we
>> fixed in commit 7ef8b52cf07 :-). Ranier, you might want to submit this
>> fix to those other projects too.
> 
> Thanks for fixing this, although I wonder if we can actually hit this,
> as we don't really allocate more than 1GB in most places. But it's
> possible, and the pre-bfa2cee code handled it fine.

Yeah, I didn't check closely I'm pretty sure none of the current 
callsites can pass anything near INT_MAX elements.

While we're at it, there's this in dicts/spell.h:

> /*
>  * Structure to store Hunspell options. Flag representation depends on flag
>  * type. These flags are about support of compound words.
>  */
> typedef struct CompoundAffixFlag
> {
>         union
>         {
>                 /* Flag name if flagMode is FM_CHAR or FM_LONG */
>                 const char *s;
>                 /* Flag name if flagMode is FM_NUM */
>                 uint32          i;
>         }                       flag;
>         /* we don't have a bsearch_arg version, so, copy FlagMode */
>         FlagMode        flagMode;
>         uint32          value;
> } CompoundAffixFlag;

We have bsearch_arg() now, so we could switch to that and remove 
'flagMode' from here.

-- 
Heikki Linnakangas
Neon (https://neon.tech)