Subject: Re: wrong relkind error messages
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com>
Date: Thu, 8 Jul 2021 09:54:58 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/08b1063f-5341-c30e-6789-b523dd0e9e29%40enterprisedb.com>
Precedence: bulk

On 02.07.21 18:10, Alvaro Herrera wrote:
> On 2021-Jun-24, Peter Eisentraut wrote:
> 
>> There might be room for some wordsmithing in a few places, but generally I
>> think this is complete.
> 
> This looks good to me.  I am +0.1 on your proposal of "cannot have
> triggers" vs Michael's "cannot create triggers", but really I could go
> with either.  Michael's idea has the disadvantage that if the user fails
> to see the trailing "s" in "triggers" they could get the idea that it's
> possible to create some other trigger; that seems impossible to miss
> with your wording.  But it's not that bad either.
> 
> It seemed odd to me at first that errdetail_relkind_not_supported()
> returns int, but I realized that it's a trick to let you write "return
> errdetail()" so you don't have to have "break" which would require one
> extra line.  Looks fine.

Thanks, committed.