Feedback-ID: ie0a040ee:Fastmail
Message-ID: <08fa9f01-373e-4cb4-9650-ad20517e2de3@eisentraut.org>
Date: Wed, 8 Jul 2026 21:24:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
To: David Rowley <dgrowleyml@gmail.com>, Greg Burd <greg@burd.me>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Chao Li <li.evan.chao@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAApHDvq=eEdw2Qp+aSzSOtTSe+h0fnVQ55CcTNqBkLDYiRZmxw@mail.gmail.com>
 <278B9FE3-F349-4494-99C5-483105C1C999@gmail.com>
 <CAApHDvoALVPgVSCuGdAfNUbxx_NacnAd0nuj8Hi=_-61AEqzaQ@mail.gmail.com>
 <1900289.1776212948@sss.pgh.pa.us>
 <CAApHDvq4_WDfTaWX6nHU8TV+no+aD1zjLphza685Ek7=xgGzew@mail.gmail.com>
 <1913188.1776220247@sss.pgh.pa.us>
 <CAApHDvp=fhr8ksuGyXkwYPXQpYvJ38YMhHvx6JmdD39cAvNRhw@mail.gmail.com>
 <CAApHDvrp6JwOVH3VwMB=YL3p97F5_0hKJc7J8zHRKuyhKru1dA@mail.gmail.com>
 <77f5109f-6d39-4cf1-8d0d-f826435d6cb6@app.fastmail.com>
 <CAApHDvqOgtX2MqaPmPmPET7=ySszzuoP3MLSUbWZit_V30VBLg@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAApHDvqOgtX2MqaPmPmPET7=ySszzuoP3MLSUbWZit_V30VBLg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/08fa9f01-373e-4cb4-9650-ad20517e2de3%40eisentraut.org>
Precedence: bulk

On 20.04.26 01:52, David Rowley wrote:
> On Mon, 20 Apr 2026 at 07:22, Greg Burd <greg@burd.me> wrote:
>> I applied, tested, and reviewed these changes.  Thanks for doing this, only a few small things jumped out.
> 
> Many thanks. I took all of those suggestions.
> 
>> SELECT test_bms_offset_members('(b 1)', -2147483648);
> 
> I made that one use member 0 instead of 1.  That'll mean "new_highest"
> goes to INT_MIN rather than INT_MIN + 1.

In the function test_random_offset_operations(), the variable seed is 
declared as type uint64, then assigned from GetCurrentTimestamp() or 
PG_GETARG_INT64(), both of which return int64, then it is passed to 
pg_prng_seed(), which takes uint64, and then it is printed using 
INT64_FORMAT.  Maybe this could be a bit more consistent?