Message-ID: <0910b47040406c1d24ec0150dafb5bae6b910ed7.camel@j-davis.com>
Subject: Re: [17] CREATE SUBSCRIPTION ... SERVER
From: Jeff Davis <pgsql@j-davis.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway
	 <mail@joeconway.com>, pgsql-hackers@postgresql.org
Date: Mon, 22 Jan 2024 11:03:50 -0800
In-Reply-To: 
 <CAExHW5uCzS-VeSYQHTHxFSdQik-f_O892xmzrzm2fuO+ro+otA@mail.gmail.com>
References: <149ff9264db27cdf724b65709fbbaee4bf316835.camel@j-davis.com>
	 <CAExHW5vv-78ixJs3arsuZ+12A4AyqehJnDPhejp0m4FAKG6JZA@mail.gmail.com>
	 <830a2bc6cbbb2e6e01c6c0d9f31f320822e10603.camel@j-davis.com>
	 <CAExHW5sAo4Gv3AwuxQNGSQ2Z45B8_MZEb-SG-B8D-hLMdrquAg@mail.gmail.com>
	 <e531ec798298a21d671babd45849092850b8675e.camel@j-davis.com>
	 <ac4042d6-204c-9661-9949-79ab8a1f8604@joeconway.com>
	 <CAExHW5unvpDv6yMSmqurHP7Du1PqoJFWVxeK-4YNm5EnoNJiSQ@mail.gmail.com>
	 <433d0845248e86c0317d9d396926182cfe157340.camel@j-davis.com>
	 <CAExHW5sQVJeCgCGMkum_k4Z4VPaK5GkdAjHW-d+F3MngBZ9qBA@mail.gmail.com>
	 <05ae37abb207cd6bf6b126780024692d91402b0b.camel@j-davis.com>
	 <93392ffa941ab0d436e19e0ab5d04d0e42c02d3f.camel@j-davis.com>
	 <26be917cb07b6aa3ef5dd15f6b59d1b375ece6e8.camel@j-davis.com>
	 <CALj2ACXDua2Az15Kj3OZFaRm49G8-faemiEEv8t9GNCcsxv8Hw@mail.gmail.com>
	 <55201bd916e748acfc754c8f95880dae8e4e5ed0.camel@j-davis.com>
	 <CAExHW5v5poohyfNRVQp3yjVE56ej0dWvVMbysSSVtg21aHT3uQ@mail.gmail.com>
	 <e71e029309171eb8b6ca393306f9bc5acfbfdf8f.camel@j-davis.com>
	 <CAExHW5vF+cp9efQj=-W+Rhbr9f9ZZqt3XFnP0NB5jKsm=C=5tw@mail.gmail.com>
	 <2a89b14a2b1622bffb8b137ca1f9ab7866f2d2b9.camel@j-davis.com>
	 <61831790a0a937038f78ce09f8dd4cef7de7456a.camel@j-davis.com>
	 <CAExHW5uCzS-VeSYQHTHxFSdQik-f_O892xmzrzm2fuO+ro+otA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/0910b47040406c1d24ec0150dafb5bae6b910ed7.camel%40j-davis.com>
Precedence: bulk

On Mon, 2024-01-22 at 18:41 +0530, Ashutosh Bapat wrote:
> 0002 adds a prefix "regress_" to almost every object that is created
> in foreign_data.sql.

psql \dew outputs the owner, which in the case of a built-in FDW is the
bootstrap superuser, which is not a stable name. I used the prefix to
exclude the built-in FDW -- if you have a better suggestion, please let
me know. (Though reading below, we might not even want a built-in FDW.)

> Dummy FDW makes me nervous. The way it's written, it may grow into a
> full-fledged postgres_fdw and in the process might acquire the same
> concerns that postgres_fdw has today. But I will study the patches
> and
> discussion around it more carefully.

I introduced that based on this comment[1].

I also thought it fit with your previous suggestion to make it work
with postgres_fdw, but I suppose it's not required. We could just not
offer the built-in FDW, and expect users to either use postgres_fdw or
create their own dummy FDW.

> I enhanced the postgres_fdw TAP test to use foreign table. Please see
> the attached patch. It works as expected. Of course a follow-on work
> will require linking the local table and its replica on the publisher
> table so that push down will work on replicated tables. But the
> concept at least works with your changes. Thanks for that.

Thank you, I'll include it in the next patch set.

> I am not sure we need a full-fledged TAP test for testing
> subscription. I wouldn't object to it, but TAP tests are heavy. It
> should be possible to write the same test as a SQL test by creating
> two databases and switching between them. Do you think it's worth
> trying that way?

I'm not entirely sure what you mean here, but I am open to test
simplifications if you see an opportunity.

Regards,
	Jeff Davis
>=20

[1]=20
https://www.postgresql.org/message-id/172273.1693403385%40sss.pgh.pa.us