Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnpFN-002Tlh-BX for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Feb 2025 01:33:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tnpFO-00AR6G-DC for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Feb 2025 01:33:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnpFO-00AR68-3j for pgsql-hackers@lists.postgresql.org; Fri, 28 Feb 2025 01:33:00 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tnpFK-0004rm-2n for pgsql-hackers@lists.postgresql.org; Fri, 28 Feb 2025 01:32:59 +0000 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-22185cddbffso47829275ad.1 for ; Thu, 27 Feb 2025 17:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740706378; x=1741311178; darn=lists.postgresql.org; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=KGZNYJuOdenps5GHNzBhsM79gqexVnxAYN16s/hABv4=; b=jvabLuEjNM05u+Zh6/VTM/X1igIG+LQXE3apLzJuu0ERd5lOH/ymSopfyGCG2Ts2XD LU7b7qPtvs3P1ofnvOFBWLh0h9fLDB9Sw4DhnAA0JqKkhEiURK3tCDcTdftpPauXm3gM E4A407lQISkmxJbP7c5w6PVp9lia+RCpBRGsF0FT2JSzotLSLhOL/QE4lbftptftBNgN +8L3n6pclXM5Z0Fts4aB+VQsTNURJUq97c70ZVyRJc3mg0pP/NAtdwoJhP+OI+B4iay0 Jpe1ZAeUnzUin+N9OlBHtaB7LOypfd8ICNoNlvtc4or5AA9Nv3A3XjUCFFthj7l4h0tc l0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740706378; x=1741311178; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KGZNYJuOdenps5GHNzBhsM79gqexVnxAYN16s/hABv4=; b=M4/0IWO4cBRt1+hRn7gODPglim3pSJJErUJSXR7PS38Nqjmp/9FI8bEUGeTr6JXuRB senUrpWK6X2DbrEvs4e4mUwbkjNBjALxlnuooorm9D616Ba5OEKsxsVnGM5EQIMMRH7R 0YoP9ep2uZygP4qx6IND8NfM0wfUjBzW7DQtUVa5sVIymLoEB3Lv0hB06lywqHiN3FLq nxz5l9wROGSv8TeWoD55B3Y1sgk+hmPO2f0ZG+sYOYr2er0NQ/fUZ/ZiwQm1SZLTq+L6 BkRDA6rfbjb/D6Uo1r8sToPNJmC3tQw+eNVEW/96xdp0bUo21Nl6g7nvdqIO7qirenxP Omew== X-Gm-Message-State: AOJu0YxIT0N6wIc2RS8Ce9trqRmh4pf1fPVszr+qXKOKdMvhNaHy6x9y XOmLQXOT5NIwtd/bTldUt23WnSl+K/P5rdzfuA3UtVhZ8ciHK/xm X-Gm-Gg: ASbGnctImr/dqfhCOGF8NEh/ZGslwb3w3CIxcKnNj0cYawxC2n/rwbUgY6RvGiw1PVo TMwhqilId0tDBp1o4lcDCfoUriN5ekVtYuFYhOqnw/3eZgRSOCTecx2Te/i1mUBvVbtJmmfuoVv P7qVDm1C4sJ+rr/bIXY5esErPILaWWxsRR13u2CSFBPeQuqDD1x0drywXi61gms//SH8JgREMsw VEwazVqM25eRL14UUHqOzny5NcPloj37qNIDNIoI5gGmmiij093CI0aVr6yo0lYB5nZMdqO667y gKrakLSzOMb8OFLl5fXEYy9Y+ZpnToIn X-Google-Smtp-Source: AGHT+IH/S+yW6Sne8xtGUCRoUCX/Zq0swuKm4whxfVEuWlpicyarA2MVmkkGmnfv/TF0cH/hbvZ0eA== X-Received: by 2002:a05:6a20:7283:b0:1ee:c598:7a87 with SMTP id adf61e73a8af0-1f2e392a9a4mr8235321637.14.1740706377870; Thu, 27 Feb 2025 17:32:57 -0800 (PST) Received: from [127.0.0.1] ([2407:cdc0:d003:2c06:badb:71b:f533:1031]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7de3ad9esm1898843a12.39.2025.02.27.17.32.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2025 17:32:57 -0800 (PST) Date: Fri, 28 Feb 2025 09:32:49 +0800 From: Zhang Mingli To: "David G. Johnston" Cc: PostgreSQL Hackers Message-ID: <096192ec-c8a1-4eec-8be4-bfd5fb2b00f9@Spark> In-Reply-To: References: <6ffeeead-0b17-487d-860b-11cc8f18a3aa@Spark> Subject: Re: Improve documentation regarding custom settings, placeholders, and the administrative functions X-Readdle-Message-ID: 096192ec-c8a1-4eec-8be4-bfd5fb2b00f9@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="67c11246_2d9e1d4b_805d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --67c11246_2d9e1d4b_805d Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On =46eb 28, 2025 at 02:27 +0800, David G. Johnston , wrote: > On Thu, =46eb 6, 2025 at 8:04=E2=80=AFAM Zhang Mingli wrote: > > On =46eb 6, 2025 at 10:49 +0800, David G. Johnston , wrote: > > > > > > Yes, and when it does it is doing so in lieu of an error,=C2=A0and = thus it is not returning the value=C2=A0of the setting.=C2=A0=C2=A0It doe= s not mean the value taken on by the named parameter is NULL, which is no= t possible. i.e., SHOW will never produce NULL. > > Hi, > > > > OK, LGTM. > > > > Thank you for the review.=C2=A0=C2=A0If you would like to add yourself = as the reviewer and mark this ready to commit here is the commitfest entr= y. > https://commitfest.postgresql.org/patch/5548/ > David J. Hi, Done. -- Zhang Mingli HashData --67c11246_2d9e1d4b_805d Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On =46eb 28, 2025 at 02:27 +0800, David G. Johnston= <david.g.johnston=40gmail.com>, wrote:
On Thu, =46= eb 6, 2025 at 8:04=E2=80=AFAM Zhang Mingli <zmlpostgres=40gmail.com> wrote:
On =46eb 6, 2025 at 10:49 +0800, David G. Johnston <david.= g.johnston=40gmail.com>, wrote:

Yes, and whe= n it does it is doing so in lieu of an error,&=23160;and thus it is not r= eturning the value&=23160;of the setting.&=23160;&=23160;It does not mean= the value taken on by the named parameter is NULL, which is not possible= . i.e., SHOW will never produce NULL.
Hi,

OK, LGTM.


Thank you fo= r the review.&=23160;&=23160;If you would like to add yourself as the rev= iewer and mark this ready to commit here is the commitfest entry.<= br /> https= ://commitfest.postgresql.org/patch/5548/
David J.
Hi, Done.


--
Zhang Mingli
HashData
--67c11246_2d9e1d4b_805d--