Message-ID: <09886ba4-727a-2048-42de-27c07ad9b3c3@enterprisedb.com>
Date: Mon, 16 May 2022 17:47:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [RFC] building postgres with meson -v8
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <498f4933-7fa9-6815-7574-1d3b2ec85daf@dunslane.net>
 <1037188.1648508299@sss.pgh.pa.us>
 <20220328231140.7ylalxc76zli6p46@alap3.anarazel.de>
 <ada92faf-77b5-30b9-669b-ba0899ef7b42@enterprisedb.com>
 <20f604f6-40be-e17b-87ac-32737743c63d@enterprisedb.com>
 <20220429174633.6io23mlwphdqdakv@alap3.anarazel.de>
 <8ced34e6-7abf-b3b2-3770-0487794753c5@enterprisedb.com>
 <20220502163602.smlwfhh2cnutxora@alap3.anarazel.de>
 <b6176b65-a138-be7e-291f-ffbddd663ed1@enterprisedb.com>
 <d4629711-d124-7afd-62b9-7ccd9c9555ed@enterprisedb.com>
 <20220512193053.kbmeaszrjs73zmox@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220512193053.kbmeaszrjs73zmox@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/09886ba4-727a-2048-42de-27c07ad9b3c3%40enterprisedb.com>
Precedence: bulk

On 12.05.22 21:30, Andres Freund wrote:
> On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
>> I fixed the Perl detection issue in my macOS environment that I had reported
>> a while ago.
> 
> Hm. I wonder if it's right to check with is_file() - perhaps there are
> platforms that have split off the include directory?

The existing code uses "test -f", so using is_file() would keep it 
working the same way.

>> After that, these configure options don't have an equivalent yet:
>>
>> --disable-rpath
>> --enable-profiling
>> --disable-thread-safety
>> --with-libedit-preferred
>>
>> The first three overlap with meson built-in functionality, so we would need
>> to check whether the desired functionality is available somehow.
> 
> Which builtin functionality does --enable-profiling overlap with? There's a
> coverage option, perhaps you were thinking of that?

I saw an option about "profile guided optimization" (b_pgo), which seems 
possibly related.

> I don't think we should add --disable-thread-safety, platforms without it also
> aren't going to support ninja / meson... IIRC Thomas was planning to submit a
> patch getting rid of it independently...

sure

>>  From 049b34b6a8dd949f0eb7987cad65f6682a6ec786 Mon Sep 17 00:00:00 2001
>> From: Peter Eisentraut <peter@eisentraut.org>
>> Date: Wed, 11 May 2022 09:06:13 +0200
>> Subject: [PATCH 3/9] meson: prereq: Refactor dtrace postprocessing make rules
>>
>> Move the dtrace postprocessing sed commands into a separate file so
>> that it can be shared by meson.  Also split the rule into two for
>> proper dependency declaration.
> 
> Hm. Using sed may be problematic on windows...

This code is only used when dtrace is enabled, which probably doesn't 
apply on Windows.