Feedback-ID: ie0a040ee:Fastmail
Message-ID: <09d4bf5d-d0fa-4c66-a1d7-5ec757609646@eisentraut.org>
Date: Wed, 10 Apr 2024 16:48:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Add tests for libpq gssencmode and sslmode options
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 pgsql-committers@lists.postgresql.org
References: <E1rtcH1-0012Sg-HH@gemulon.postgresql.org>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <E1rtcH1-0012Sg-HH@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/09d4bf5d-d0fa-4c66-a1d7-5ec757609646%40eisentraut.org>
Precedence: bulk

On 08.04.24 01:50, Heikki Linnakangas wrote:
> Add tests for libpq gssencmode and sslmode options

Why aren't these tests at 
src/interfaces/libpq/t/nnn_negotiate_encryption.pl ?

> Test all combinations of gssencmode, sslmode, whether the server
> supports SSL and/or GSSAPI encryption, and whether they are accepted
> by pg_hba.conf. This is in preparation for refactoring that code in
> libpq, and for adding a new option for "direct SSL" connections, which
> adds another dimension to the logic.
> 
> If we add even more options in the future, testing all combinations
> will become unwieldy and we'll need to rethink this, but for now an
> exhaustive test is nice.
> 
> Author: Heikki Linnakangas, Matthias van de Meent
> Reviewed-by: Jacob Champion
> Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f
> 
> Modified Files
> --------------
> .cirrus.tasks.yml                                  |   2 +-
> src/test/libpq_encryption/Makefile                 |  25 +
> src/test/libpq_encryption/README                   |  31 ++
> src/test/libpq_encryption/meson.build              |  18 +
> .../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++
> src/test/meson.build                               |   1 +
> 6 files changed, 624 insertions(+), 1 deletion(-)
>