Content-Type: multipart/alternative;
	boundary="------------hWizscBYso0iNdiGCV9AGB6A"
Message-ID: <09df1227-4f6f-6b4e-1503-697fd110bb9d@amazon.com>
Date: Thu, 8 Sep 2022 11:29:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.1
Subject: Re: more descriptive message for process termination due to
 max_slot_wal_keep_size
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
CC: <sawada.mshk@gmail.com>, <ashutosh.bapat.oss@gmail.com>,
	<pgsql-hackers@postgresql.org>
References: <03ee95c3-6496-90b7-5c8b-13fe69ee73dd@amazon.com>
 <20220907.112019.758274712731312487.horikyota.ntt@gmail.com>
 <95534909-b8a0-d447-b940-b91006397962@amazon.com>
 <20220908.134020.228552226800754222.horikyota.ntt@gmail.com>
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: <20220908.134020.228552226800754222.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/09df1227-4f6f-6b4e-1503-697fd110bb9d%40amazon.com>
Precedence: bulk

--------------hWizscBYso0iNdiGCV9AGB6A
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 9/8/22 6:40 AM, Kyotaro Horiguchi wrote:
> At Wed, 7 Sep 2022 12:16:29 +0200, "Drouvot, Bertrand"<bdrouvot@amazon.com>  wrote in
>>>> LOG: terminating process 49539 to release replication slot "rep1"
>>>> because its restart_lsn 0/3038000 exceeds the limit by 15.8 MB
>>> If the distance were 1 byte, it is shown as "0.1 MB".
>> Right and I'm -1 on it, I think we should stick to the "pretty" or the
>> "bytes only" approach (my preference being the bytes only one).
> Okay. the points you brought up above are sufficient grounds for not
> doing so.  Now they are in the following format.
>
>>> LOG: terminating process 16034 to release replication slot "rep1"
>>> because its restart_lsn 0/3158000 exceeds the limit by 15368192 bytes
> Thank you for the discussion, Bertrand!

You are welcome, thanks for the patch!

It looks good to me, barring any objections i think we can mark the CF 
entry as Ready for Committer.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com

--------------hWizscBYso0iNdiGCV9AGB6A
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#415ce2" bgcolor="#FFFFFF">
    <p>Hi,<br>
    </p>
    <div class="moz-cite-prefix">On 9/8/22 6:40 AM, Kyotaro Horiguchi
      wrote:
    </div>
    <blockquote type="cite"
      cite="mid:20220908.134020.228552226800754222.horikyota.ntt@gmail.com">
      <pre class="moz-quote-pre" wrap="">
At Wed, 7 Sep 2022 12:16:29 +0200, "Drouvot, Bertrand" <a class="moz-txt-link-rfc2396E" href="mailto:bdrouvot@amazon.com">&lt;bdrouvot@amazon.com&gt;</a> wrote in
</pre>
      <blockquote type="cite">
        <blockquote type="cite">
          <blockquote type="cite">
            <pre class="moz-quote-pre" wrap="">LOG: terminating process 49539 to release replication slot "rep1"
because its restart_lsn 0/3038000 exceeds the limit by 15.8 MB
</pre>
          </blockquote>
          <pre class="moz-quote-pre" wrap="">If the distance were 1 byte, it is shown as "0.1 MB".
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
Right and I'm -1 on it, I think we should stick to the "pretty" or the
"bytes only" approach (my preference being the bytes only one).
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Okay. the points you brought up above are sufficient grounds for not
doing so.  Now they are in the following format.

</pre>
      <blockquote type="cite">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">LOG: terminating process 16034 to release replication slot "rep1"
because its restart_lsn 0/3158000 exceeds the limit by 15368192 bytes
</pre>
        </blockquote>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Thank you for the discussion, Bertrand!</pre>
    </blockquote>
    <p>You are welcome, thanks for the patch!<br>
    </p>
    <p>It looks good to me, barring any objections i think we can mark
      the CF entry as Ready for Committer.<br>
    </p>
    <p>Regards,<br>
    </p>
    <pre class="moz-signature" cols="72">-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: <a class="moz-txt-link-freetext" href="https://aws.amazon.com">https://aws.amazon.com</a></pre>
  </body>
</html>

--------------hWizscBYso0iNdiGCV9AGB6A--