Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzqI8-0003Yk-EA for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 22:06:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzqI7-0003YB-7P for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 22:06:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzqI6-0003Y4-LQ for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2019 22:06:03 +0000 Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzqI3-00006b-Is for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2019 22:06:02 +0000 Received: by mail-yw1-xc44.google.com with SMTP id u205so15332360ywe.1 for ; Fri, 01 Mar 2019 14:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to; bh=EtPtJvBhsrtATeaNyUPM7/k3PchR3Oa2OYcp/90xFxU=; b=RN9jJ4ef54OWiVstoF13/sLVzCpCkGY3aNXlHsnQbKbrXG0Ys9HFx9vIlidiT+CKWj IVYR3wcqXrkaZodAuYCP1ktZcJVpA1+eJj9+MbTCIktdbvLB6enp04SdqXVAYZwuQ0de O3zB21FLtQFSLsx4ZRMSilkXYPzNwVTHxjAGC+Rx+wMZU2lK/EH7FWEWHZvNumEuye44 /Z9sLzEcg8wJPr0FKUSLmor5r6gvEtvutxpUfSMImVPOIWBjIJahayYAmUBJMjs1dIUU iMLWun8sQo/Rm7PgTOD3EQ+4LgIxvSQxOf/sNDBjGG3XJHQgkx+Lilqejozr0SGREfNY rSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=EtPtJvBhsrtATeaNyUPM7/k3PchR3Oa2OYcp/90xFxU=; b=pftQPmUZlhtNd6Pxyz7bJhOuMNohCwicLdYd6JFTRpJfEPA2ECPNYORVGWSFUxDLmQ zeE8Sy3QLAthb9+JnaKDKq6/BPgXrqctInSFlRkVQRB2aYIx7bfPl0yId92/XSOfeWTX M9hEaq+9DmKPP8R2jXRk3ZPdp2nZVTKj03rYYz4h2ytFodWOosRMSVVlRh1DBXugvJ4X Owis9frWqRyIdcbm2fuPtykmj4Bpm9fzKhHbqPqvgmZ9aeAzyi2tC4Cpv0wk2171U71y FYtspMF4+kQ7RtDKshenGo2AizOw/x9NC/VE4ixf0300ayvJ6iW8ZFhYDuJoJ4lB9Tq0 sqBA== X-Gm-Message-State: APjAAAWyF8tQ2374gDQTTQpK6yTD2LeI80rpnUtxpeu5JpewDUZs/4zV sWq6+QdiO42ZvhXSwzLiKLXsggcZCILSZw== X-Google-Smtp-Source: APXvYqzsw5wnzNQ9ZOfu0ZZDWMW9v+uEu24kyKHZGanWlYGeH42hQd0bL0wAn/E27O41nuynUGRZcw== X-Received: by 2002:a25:800d:: with SMTP id m13mr6108622ybk.306.1551477956885; Fri, 01 Mar 2019 14:05:56 -0800 (PST) Received: from [192.168.4.41] ([72.17.18.98]) by smtp.gmail.com with ESMTPSA id l144sm5730977ywb.75.2019.03.01.14.05.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 14:05:56 -0800 (PST) Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile To: Michael Paquier , Postgres hackers References: <20190301023338.GD1348@paquier.xyz> From: Joe Conway Openpgp: preference=signencrypt Autocrypt: addr=mail@joeconway.com; keydata= mQINBEpXMCsBEADDnXUQzjlyi/cX02Gtdy2CLcroE5CsC7DJKdOBDbfgn0kfiIYoV5JniG4l VyzZUodY8yUAagqLYolh0UkBzs9N+qkm7erde4ypw3jzVQ37BuzIvk3nMUbuDZDgxWqX+nVS sKc+BQ5BpzgCHg48leoRO2ohjvYnUhgH3j2rFZCzaj6qQ7mv+XoxOJmUlVQtG06Jwkk7Vu14 7U9nMMM6hyUKzVnmCphnlcMNo26UyVU70MwFfFJgcI0c5fpp8byN56eD6VJVnufO5WAuEhzE qcrSJR2FAlmM90GBY+6vP29twLDCHuSFvrnujNCx/BvCC/a3/gPvyAFp4JtMm9eXAmq3m/Kw 94nTJXVdcbQeQQDp3KIG7MmWS4lnGvPn8v0CjgNaLvZXFLo1FgmUVsyEq1Lww4iRLa6sbpXJ ESx15UEue1k1YZM9C+4F/o3aeKNsAienjw2EXFzcaxIg/C4P493VMi3Qa8ycVxR5iYhUbYdo DFIUQhbFNsYfrtW/qZAELT3FCYFpZYG01e9Hj+cBrXXgyDDkQ5Lq4mlvmkRvuxn61V6Au4HA 0sJiCox5pM1FvzT+aI8HY1BYaiB9Pl4fhpKgmhhlSuglk9v39S4jmlUIb45iLAUVpeNM6Qjm 69pf5da9sm4aGFa7YlDSKf/WcU7z9ITZxsilOi2n7YJiwG7kTQARAQABtB9Kb2UgQ29ud2F5 IDxtYWlsQGpvZWNvbndheS5jb20+iQI8BBMBAgAmAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwEC HgECF4AFAlpoksUCGQEACgkQMyt+aLaZQ0p4XQ/9F4WSf4ZFuL3ae356ApVqnLxphHXeXHli ePZe7qosvXMQLN9Y2m5cQwqojsQh4pZujIi4Iwxw7ORg6HbMO8dMhyu8TlDavErcgO561hG7 /TCcCLf5SkadxBqYWAJH09W8S2iC3gQtS+qs4Y7sIvRi881EsPzG5Lrzu7Ei8ufqsSnbLUQk zAaKjK3IzAFvzA3VCg/8Aqhf8obhqL0j5I5DNOpAt2U4gkEzIrX1g5xSXpRLMHLEK7hPViY8 pFQyRvyZioE4hckNsnidCgiv4HefJUFRIVxDkHBeLhTzqTPloesFT/bskhckIS6F4suMx044 WTTW6UiARuWw3aaBTmxay2rjPCsGaJPawzY0O3HlNlZherCzuBpa+Qk1kMLkcxMlYjCrMgIR YyBpIK46ltPQaog4Ujh21w1Z8m/ufG5v/HTuLdXM9hGfTlW7aY6psCAV/MwfycDHLRMc+UY7 W2cp6DlWQ7GHLP+vzvBcl5Odi04EhcYnHMZjKvRFsxhE0LZcTejrtxPkDgR9G59irlIx1+py ziK2B0hs7Er1Yq7qQGQiQGLoglSNDsvsUeyMGyabasmUd5xrRO35SpGv+hyYGAZ3Pyk9Vtxl CO7BJkZiV9YSMHp6hOdmYZd4SZRChd9sKd6eSw1xIlBALz1ZHuQVMBuZvuVGFsS81Zqckb/2 D5q5Ag0ESlcx7QEQAKhm5UhGfbe3hM4yCaa/pPaNaswlB2tK1DHAjDlDm7gDVEodfsrvAFUU unLodlvCd0g/GpLmXXdROU/I+HusVqQhDbVeHMwO2VUVHamRWqDfrCjMYVxLz80d96TYyeyW 6RUNkJmXJAOKgy8veI7Z1F+j1gXQR7UlzonnSkWbs0oQ3RglvyqhkUzWtXU7F+j2hQ2vQsct Lnq3lYo0bYkZ3K6RyKZXSly9Hd7DzYkMzz7StNRlyeQJxplPrVPup7N8SqDrI126sq0cwdUB Gn1sKVoO+bGidBjhJgxouNPkMJlPjbKOgb7tv5ZnM33FGXNdC5sPKoZ4mC+gaqRHYaH/V61v fCo1CYNLIK+Cj+Oua8mQ6CPeOb5VKcJ0JM96eGNlzF9EawppOG7xCDcbmBEr0m1go9MHEUel 0L1i8RSDYOHQQkLT2MVWYf4UsRlEGbME+kF7DEX9Fvie7qglFTXC2d+YVN73AnXcoM/IYUOR DXjVVaqQoHuA4uxwJ31o/rEaOihr2yCScr8mB8J3b3KyNfuCBm5gN0tUQw+t5szMYurDpZ1G L4O7btaQ5u4iJMfRTCnPrzW+wkdVrao7AmRNWEtSlXsycClKFCHz/Ej5rpXOKSp+a/xcaFX1 v2eS/+Ujp5ESu9p57JwlP6aSqYBiOALRJXZ9DVtZL96okjzXjrd7ABEBAAGJBD4EGAEIAAkF AkpXMe0CGwICKQkQMyt+aLaZQ0rBXSAEGQEIAAYFAkpXMe0ACgkQN/L3QzX32GV1Jw//fhvL Mk1YNS/2N5jc5HYmEjcL2OWBLLrO5RMCaOgCNmYsepkigy2U+GSloVy8Y40/UfYzIoNf1DiB Qyj5Ipa4eMjfKA7+1q43a5wkDDWogFNflKTTNemwrHDKR1WWDrxt8uAgJdlBGDQA7A0q3D2i Xhd7ALLOHhuXDY1++N9TK9KMfV90Oay0mIMLQhTG/UgsgrYYb78H2pk8XMYZY29vgZlj9VH2 f1RpOoh7lCaB+2glN27Rzh17q0/zEjwXk4sDyYHRIycaqnM4ozSnliXyoWM5bvmqSGBCm5jl BjNW+cFbFy15U595AIXXiUXl8hsTF2JWwgHr+hYdtoEH3oEOxzM18ENXKTTgN+BafdMsah4e HIcVvrVrH6rlsPwCvk3o/PJ07qVbUW+dbZG8UB1JwqUUqGhrCk87kztajlvZGZWxWDSB4Lnb T6Jc0L7/YXG8U3sJ2OtZ95Lal5XfNo0yBdPflmalH3xf/EcxaYFETbDrY5UgEVa2HBw8XzKk rTbM8rD318M+jBOuL6o3cGMOeFOm4C51fJZmOCFd03LhMkoj9IbLIPGKosIBsxb7zP5YLAbI b3el6pvo9CKtNuR+IcVOoFtH+KVOxGsbbxFEFbsAmPMreF1hIv+l+HXBaDhUkaUmpJ1Mhxol aM6O/LGG4VQV7wBQFunVaN8EPqMqYDph3A//TjQVd8fqvw5Ezj1958IUmV0jxeGX2m/fspGh njF+6Adx3PFbZoKyW71cA/TnlHVYCaizjYYRNMC3g5VFytOYOZFi0GKsxQTX5PcPhDjFFTUv FVVZwDYUK3QlC+wGDTeNWfAJIZnTPPIXSiHzh3si+ngKjE+ngcRF1VY5K4xvc6ss6uq8kI8L Ct+TpOMr99ijaYEbMZ8WJagynD5BLNYxpP6CCTMDi1Xqydg0E/mhR9w9aUOvdTZw1OOKtLnz B1E0wFbzJXEvjP2eEVNlStS5RTawFDpqxGwXJcHqe8qtg8B+C1r47RmHnKKm+DTOPFQWTj83 l775aNMzAHm+Pr1TdSA5XRyQ3wxwYKfhp1suKhILUZLjbiCQf92RZQ6yEdXskMr2A4n0GQWq Q8k7r9QPqtUP7lsiyyDem7r9h5mAm94r3Td22L3JaSHkBD+4jC4gIXeYoyd+lTz/zYOx0Fri J8dXHalmyTGsSxV7FXv1/thVEf6R7TDdVwhqf/WL3uWTmVBR0tJscG+9iCVch/OG/uCDkWZQ sOTotqj6f5jSZI+NOUqt62+8i8gjYEa7zRZ2HXFOTV8UduCjheWB2VCUj5EjFjTMjfTVkyZ5 SiFht7bM5l/odoYU6vn37/5s/ZsMTZX1zG5oXv6iULrHLYHhUxR93FlVyn4DiHsWND/Idj65 Ag0ESlcyJwEQAOkTBb9yDhJbMUgvhM11rZwT5tm4Y9TqtEHn0Zy3t9g7bdFFpMvav/KENd3o AtLFpMDf+H3AggFk4ftUwJwiVgJ88ilvCynJUGXiuYIaexY4DLgn4xpnuiEpYEFVdWnlw7dW VTc62exfqIz9bSWRzwfBCY9ruYGEb4RDPDSNSAVyI7sxHzef2asiYxIcxrTrw5VugWNlPZcV 5/EJ6PUvATjBF2TBkXV7KOciQng2tsQGrGMkY5mduNqwpuh6zfPcVF8LeObe96wv5ZhPRpO7 9nef7hnK2lJogp3JIo558Jlbz9WHtQEMZR85+bUhtI825QyNAFz3Jrn7NMgvDikc2OrWo7YM gMC5hDSWVFqA6/EQCNnDWGABWgeYHZFpnPwsvUWIYdhSilUuj/Tuzvz9ZmucFNbQbauDQw6V Q38ofGnoYDZFJsGncprB8dBi4tDrIQ+1RlIh6C2Z/eMipqJOT26+spluTjouvnKT0S5yOgyX 0PjbsysgwQdCGNJLHOjhHbSpSmOLaduV3CQo/0+DHT/TBjYfIXjTWouY9TkGxG4eNrxU0u2x Ay5bMqOPmsFdjLTWlQUlF/fTMhB54XwI3FHWgnSnXZzStDTmTebLNdT/ftgliAzA81uMj49j 0exv731/v+7udLA1bV8gnZ01zQCASDpWiRQR3fgwcugSUqgRABEBAAGJAh8EGAEIAAkFAkpX MicCGwwACgkQMyt+aLaZQ0pwAQ//bjcWnZg/jjRQ9gbZUGMqniItZYRglBMKIqt4Fia379Jm HwTvavnFkJ8XMZ56UB0FIrgS+sUkRH6cPRQR+7Qi392LD021DXgSsz9CwFHjFyBGHwLEOTRc fYQbtJy0shHDJB4aQTOX3ERDH1PsvJNuevmQMzS0DWFav9+xMz9rKP4N+HffoBIZE0C1xIE4 3nD4eLsbycte9sVIrmlNuUti3qUxJAQw8HwfJ6ZbBInHxquApR16uD1u99o6XlndFrDlY22t RmHCM0bR81GfGNdcU3Uo+rG/R/k4qa7s9/dgKvMbyH3fHhp/ceKag80Xo8IFurRl0ZJP3sHJ 2QDHCVLat7jRZ+43hi1WlIhFbrgn6IyI0i7XR/W8JjrC5MsKq4TUwGH077sU/kcHYebVJZRb UUst2hAGHDFVBcG12qoKf+ltL9qXJc1y7BGeCoUW6QjOpljpq6ZL4FQUsM0RSRjs5egE3szP cIf5SyPK6WDOApoAq6M7BBFMGDZwEylYMtr0YekA1u86UA9D2xwLHEbBBp/uiby1c9JbPJ1P n8zJP8WZNeRw4Q9TtqVK09+oLirMUSpIDd6KdZ1VgRxOK2re7tjDvkVuYsSrsiJ+1iJNEnp9 iK0ok0DlJpSCe6KhkxpaTdeoWMXdKuJWec0NIqoAd54ZgBPnr+UPxTixgPq/p6Q= Message-ID: <09ffc3a3-0e1d-91c6-7748-890b1829469a@joeconway.com> Date: Fri, 1 Mar 2019 17:05:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190301023338.GD1348@paquier.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jrZW8BffTZVPgSZB3ry7tXLlo0UjGHZ9V" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jrZW8BffTZVPgSZB3ry7tXLlo0UjGHZ9V Content-Type: multipart/mixed; boundary="64c33MKkTkLw9qDAaf1UCgkDpquZVpp2i"; protected-headers="v1" From: Joe Conway To: Michael Paquier , Postgres hackers Message-ID: <09ffc3a3-0e1d-91c6-7748-890b1829469a@joeconway.com> Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile References: <20190301023338.GD1348@paquier.xyz> In-Reply-To: <20190301023338.GD1348@paquier.xyz> --64c33MKkTkLw9qDAaf1UCgkDpquZVpp2i Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2/28/19 9:33 PM, Michael Paquier wrote: > Hi all, >=20 > Joe's message here has reminded me that we have lacked a lot of error > handling around CloseTransientFile(): > https://www.postgresql.org/message-id/c49b69ec-e2f7-ff33-4f17-0eaa4f2ce= f27@joeconway.com >=20 > This has been mentioned by Alvaro a couple of months ago (cannot find > the thread about that at quick glance), and I just forgot about it at > that time. Anyway, attached is a patch to do some cleanup for all > that: > - Switch OpenTransientFile to read-only where sufficient. > - Add more error handling for CloseTransientFile > A major take of this patch is to make sure that the new error messages > generated have an elevel consistent with their neighbors. >=20 > Just on time for this last CF. Thoughts? Seems like it would be better to modify the arguments to CloseTransientFile() to include the filename being closed, errorlevel, and fail_on_error or something similar. Then all the repeated ereport stanzas could be eliminated. Joe --=20 Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development --64c33MKkTkLw9qDAaf1UCgkDpquZVpp2i-- --jrZW8BffTZVPgSZB3ry7tXLlo0UjGHZ9V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEg14x9eymXoJyHrH+N/L3QzX32GUFAlx5rMMACgkQN/L3QzX3 2GXXpQ/9GJynNFKc2NXJp7VZV7jvD9xJ/kNTaGYpXwvbi+O3PlzMAazbuMhztB5P 2B/Dl2L3aQihtWabiIhVMywBS9/1Ycl1j0VLpMdkSjk4hJpnsriqgMU7XrJGDfZ2 vLH4Jhg0N5EqT+lLrOybwpHv1euNb9ZWl+TMaVFzHLQ8tlXYVxzNW4egr2+uNWuq f6vnfzHhemSIbZianuTdH6Uzq1VUXVzRAJqe1Dk7ynO3U5v6eA/wpc6kVvaVZRps G1zQzm5Vfzfv4EM5vVp58XKuqhj4NYFYZRdKacW7NkvAyEmmR0N0qP/wQnMm9BGW cRR0NgyY3aIOQy5iniBFjYNsZDvGmNkmvsHFsgmj6aedLaw2n8pdbjd0r6yZPMEw sxZbeyy/aAUhkeScbSR/z+4DRny1nqcfh9CKrRbj/OWmSiooSgdAe/0l3YSKGQnE CoLMY9kSI6EthWbSX5zKNxcXzhaqPuO9OIRE5TKC2jTtCV5FJaEDNlKNLVdU0N+X kdKjJAMxOAQW96fW0nJ+TxQxNKqRp5ITp2HYfca0JUD9XPGIrTbUT6lHd1gyGOZJ W9iKhdqV7ax6XLHGPCXI8kSNY6biLEenCxHHxLmJaYqaWPqaqUvUOOsv0LLysj/l nd9qt9/0rwBewxnGAr13IUlDM8mZwXep+GU4v6BWuDnHSUHdGZk= =7Ypa -----END PGP SIGNATURE----- --jrZW8BffTZVPgSZB3ry7tXLlo0UjGHZ9V--