Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: [PATCH] Clean up property graph error messages
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
Date: Tue, 5 May 2026 10:50:09 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0ABA607E-665C-4E25-93EB-A21DF9616E84@gmail.com>
References: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/0ABA607E-665C-4E25-93EB-A21DF9616E84%40gmail.com>
Precedence: bulk


> On May 5, 2026, at 03:57, Ayush Tiwari <ayushtiwari.slg01@gmail.com> =
wrote:
>=20
> Hi,
>=20
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
>=20
> The attached patch fixes a user-visible error message from =
"mismatching
> properties names" to "mismatching property names=E2=80=9D,

I think changing =E2=80=9Cproperties names=E2=80=9D to =E2=80=9Cproperty =
names=E2=80=9D is correct.

I wonder if we can also change =E2=80=9Cmismatching=E2=80=9D to =
=E2=80=9Cmismatched=E2=80=9D, so the error message is:
```
"mismatched property names in definition of label \"%s\""
```


> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties(). =20
>=20
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit =
ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.
>=20

Agreed.


> The regression expected output is updated for the changed error text.
>=20
> [On a separate note, it might be better to change all "vertexes" to =
"vertices",
> haven't included that in the patch though since the other one is not =
exactly
> wrong?]
>=20
> Regards,
> Ayus
> <v1-0001-Clean-up-property-graph-error-messages.patch>

So, v1 LGTM. Only thing is that I think we can also make =
=E2=80=9Cmismatching=E2=80=9D to =E2=80=9Cmismatched=E2=80=9D in the =
errmsg.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/