Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Do we still need gen_node_support.pl's nodetag ABI stability
 check?
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <2233110.1776304006@sss.pgh.pa.us>
Date: Thu, 16 Apr 2026 16:33:23 +0200
Cc: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0B7ADF2E-D2D2-4B3C-BD85-2B6A44D14344@yesql.se>
References: <1458883.1776143073@sss.pgh.pa.us>
 <cd9faf75-370f-4305-9644-299e4404692b@eisentraut.org>
 <1977660F-C5E3-427B-AD2F-56F66803C320@yesql.se>
 <2233110.1776304006@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/0B7ADF2E-D2D2-4B3C-BD85-2B6A44D14344%40yesql.se>
Precedence: bulk

> On 16 Apr 2026, at 03:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 15 Apr 2026, at 21:30, Peter Eisentraut <peter@eisentraut.org> =
wrote:
>>> This might still be helpful because it checks during local builds =
and doesn't rely on the buildfarm.
>=20
>> But does it actually give a good enough answer to be relied upon when =
passing
>> the local check can fail the buildfarm check?
>=20
> Yeah, my answer to that is still "why is this particular case more
> important than any other ABI breakage you might cause while hacking
> on a back branch?".  I quite agree that being able to check for ABI
> breakage locally can be useful. =20

Agreed.

> But what we ought to do is make it
> easier for people to use libabigail for that without spinning up a
> local buildfarm instance.  Perhaps we could extract the buildfarm's
> ABICompCheck.pm script into some standalone tool.

While I have zero insights into how complicated that would be, off the =
cuff it
seems like the right approach.

--
Daniel Gustafsson