Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUlb2-001Qjr-1j for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 13:25:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUlb1-001dXc-0r for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 13:25:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUlb0-001dXU-2o for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 13:25:22 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wUlay-000000013WB-3jfx for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 13:25:22 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 804C55DC8AF for ; Wed, 03 Jun 2026 15:25:19 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 71D4A5DCB34; Wed, 03 Jun 2026 15:25:19 +0200 (CEST) Received: from localhost (unknown [172.22.191.6]) by s980.loopia.se (Postfix) with ESMTP id 6EF9F2201512; Wed, 03 Jun 2026 15:25:19 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s898.loopia.se (amavis); dkim=pass (2048-bit key) header.d=yesql.se Received: from s980.loopia.se ([172.22.191.5]) by localhost (s898.loopia.se [172.22.190.17]) (amavis, port 10024) with UTF8LMTP id DpFKKSC8Y1Zr; Wed, 3 Jun 2026 15:25:19 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.236 Received: from smtpclient.apple (customer-89-255-232-236.stosn.net [89.255.232.236]) (Authenticated sender: daniel@yesql.se) by s980.loopia.se (Postfix) with ESMTPSA id DD5A4220166F; Wed, 03 Jun 2026 15:25:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1780493118; bh=o0PSV/zUsprmobYM5g1gFwgP9s1POsfpB6k134tfbGk=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=qZfOAdfx9zrQzlB6EBo/EizY7qd/cIWrfYiza6hqGHtzqLgmfUaASV2vzhiFZ50Ll hsWpTuwkbXmD6riDjneF0a8j4OOAGKTZOeO4j3gbJ+OZTpCTJlef/wbO1H5fCNZT9N +PUYOVE4cFaNl/OTCbphBzTpTi+n2VFsWfxaIfJ24R/K4MIvml3rG5wNrMaDJdM9ed cpqNQ2DlLjqUUGy5hJrf1/yhSd0P8WaVy0JmAvP/wxXE3T0nfCeC42MTX/yp7PBQYB RdqwvPH/VVTQOis6GkhwxgxtV0vGgy0ilXLoeoX4gfK1m7Sx8K006RPygi1jv1AxHP BQGNkSzDmcIag== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\)) Subject: Re: Use streaming read I/O when enabling data checksums online From: Daniel Gustafsson X-Priority: 3 In-Reply-To: Date: Wed, 3 Jun 2026 15:25:08 +0200 Cc: pgsql-hackers Content-Transfer-Encoding: quoted-printable Message-Id: <0CA37C20-1A2D-4897-9C5E-360E357414D6@yesql.se> References: To: cca5507 X-Mailer: Apple Mail (2.3776.700.51.11.12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 3 Jun 2026, at 13:10, cca5507 wrote: > Attach a simple patch for $subject. I think we prefer streaming IO = instead of > ReadBufferExtended(). Do I miss something? Thanks! This code was written well before read streams existed, and = recent work was focused on correctness of operation, that's the main reason = it's using ReadBufferExtended still. We probably want do something like this once = the tree opens up after the v19 feature freeze. -- Daniel Gustafsson