From: Jim Nasby <jnasby@upgrade.com>
Message-Id: <0E5557BC-50FC-400F-BE96-11922C0C11EE@upgrade.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_37FB5F69-D26E-454D-80E7-48B8712587C1"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\))
Subject: Re: Vacuum statistics
Date: Thu, 2 Jan 2025 15:14:13 -0600
In-Reply-To: <CAA5RZ0sjDx6QFRJJ+e=orwvLboLWO42f2qF0_HbDq-sMq=tW4g@mail.gmail.com>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>,
 Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
 Andrei Zubkov <zubkov@moonset.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 a.lepikhov@postgrespro.ru,
 Alexander Korotkov <aekorotkov@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru>
 <CAD21AoAVK7DwTZLfhwuRhTGgR=_ASu5YshEg_Cmpojk5ZdZ3tA@mail.gmail.com>
 <CAAKRu_auu=xt4w3Mm_jW-voJunZgno6XDDohH6hhRc4Z9dGdYQ@mail.gmail.com>
 <CAD21AoD66b3u28n=73kudgMp5wiGiyYUN9LuC9z2ka6YTru5Gw@mail.gmail.com>
 <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru>
 <CAPpHfduwY8-fp34CuO9O57ouCs1K=Gn1rTnuG4AaWYhEo6nXyw@mail.gmail.com>
 <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com>
 <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru>
 <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com>
 <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru>
 <E0B6D242-C16D-4848-930E-B693D4E5C678@upgrade.com>
 <e2003f94-2075-4183-8298-9d25d8431fb1@postgrespro.ru>
 <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com>
 <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru>
 <CAPpHfds=woPcB9nPtMmu=g=U9q6-FHFh7fF_x=uhU3k2Oi03sA@mail.gmail.com>
 <f972c2c9-edcc-49b8-9f23-6208eedc3d23@tantorlabs.com>
 <77e6e723-0d3e-4235-8386-03d143916125@postgrespro.ru>
 <CAA5RZ0sjDx6QFRJJ+e=orwvLboLWO42f2qF0_HbDq-sMq=tW4g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/0E5557BC-50FC-400F-BE96-11922C0C11EE%40upgrade.com>
Precedence: bulk


--Apple-Mail=_37FB5F69-D26E-454D-80E7-48B8712587C1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Jan 2, 2025, at 2:12=E2=80=AFPM, Sami Imseih <samimseih@gmail.com> =
wrote:
>=20
> Alternatively, we can remove the vacuum related stats from =
pg_stat_all_tables,
> but that will break monitoring tools and will leave us with the =
(auto)analyze
> metrics alone in pg_stat_all_tables. This sounds very ugly.

While backwards compatibility is important, there=E2=80=99s definitely =
precedent for changing what shows up in the catalog. IMHO it=E2=80=99s =
better to bite the bullet and move those fields instead of having vacuum =
stats spread across two different views.=

--Apple-Mail=_37FB5F69-D26E-454D-80E7-48B8712587C1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><blockquote type=3D"cite"><div>On Jan 2, =
2025, at 2:12=E2=80=AFPM, Sami Imseih &lt;samimseih@gmail.com&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div><span =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; =
display: inline !important;">Alternatively, we can remove the vacuum =
related stats from pg_stat_all_tables,</span><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: Helvetica; font-size: 12px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;">but =
that will break monitoring tools and will leave us with the =
(auto)analyze</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;"><span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; =
font-size: 12px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; =
text-indent: 0px; text-transform: none; white-space: normal; =
word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none; float: none; display: inline !important;">metrics alone in =
pg_stat_all_tables. This sounds very =
ugly.</span></div></blockquote></div><br><div>While backwards =
compatibility is important, there=E2=80=99s definitely precedent for =
changing what shows up in the catalog. IMHO it=E2=80=99s better to bite =
the bullet and move those fields instead of having vacuum stats spread =
across two different views.</div></body></html>=

--Apple-Mail=_37FB5F69-D26E-454D-80E7-48B8712587C1--