public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Fujii Masao <[email protected]>
Cc: jian he <[email protected]>
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: COPY FROM ON_ERROR SET_NULL bypasses domain NOT NULL with partial column list
Date: Tue, 19 May 2026 06:27:54 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwEvUj+ycr5vYMPQhZ8gk1of4HiSGfKVBJ15nA8d3MyDhQ@mail.gmail.com>
References: <CAHg+QDdej0c0gWJi2FnbirzhgzyZNPiTwC1P5B_-dSNCzq-91A@mail.gmail.com>
	<CACJufxEYGY5twGooBDU4ttpb0SOQuOb8dYKoBsEML8dObAf4ZQ@mail.gmail.com>
	<CAHGQGwEvUj+ycr5vYMPQhZ8gk1of4HiSGfKVBJ15nA8d3MyDhQ@mail.gmail.com>



> On May 18, 2026, at 21:22, Fujii Masao <[email protected]> wrote:
> 
> On Fri, Apr 17, 2026 at 12:59 PM jian he <[email protected]> wrote:
>> 
>> On Fri, Apr 17, 2026 at 1:09 AM SATYANARAYANA NARLAPURAM
>> <[email protected]> wrote:
>>> 
>>> HI hackers,
>>> 
>>> domain_with_constraint[] was allocated with list_length(attnumlist)
>>> elements and indexed sequentially via foreach_current_index(), but
>>> copyfromparse.c accesses it via attnum - 1 (physical attribute index).
>>> With a partial column list targeting high-numbered columns, this caused
>>> an out-of-bounds read that bypassed domain NOT NULL checks, silently
>>> inserting NULL into NOT NULL domain columns.
>>> 
>>> Fix by allocating with num_phys_attrs and indexing by attnum - 1,
>>> consistent with all other per-column arrays in BeginCopyFrom().
>>> 
>>> Patch is attached, and added a new test case to cover this scenario.
>>> 
>> 
>> The patch looks good to me.
>> I simplified the tests.
> 
> The patch looks good to me. Barring any objections, I will commit it.
> 
> Regards,
> 
> -- 
> Fujii Masao

I also found this bug and reported it here [1]. I just reviewed v2, the code change of the fix itself is exactly the same as my version in [1]. The new test is slightly different from my version, but I think that also works.

[1] https://www.postgresql.org/message-id/8A72720A-55AC-4D41-B9DF-5610307600E6%40gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: COPY FROM ON_ERROR SET_NULL bypasses domain NOT NULL with partial column list
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox