Content-Type: multipart/alternative;
 boundary="------------u0PuCafMjfjF03rASxGZfHSZ"
Message-ID: <0a617d34-abc3-4090-92a5-ea15d45e36f6@gmail.com>
Date: Sun, 15 Jun 2025 18:00:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Slot's restart_lsn may point to removed WAL segment after hard
 restart unexpectedly
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Vitaly Davydov <v.davydov@postgrespro.ru>,
 Amit Kapila <amit.kapila16@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Masahiko Sawada <sawada.mshk@gmail.com>, tomas@vondra.me
References: <1d12d2-67235980-35-19a406a0@63439497>
 <CAPpHfdtp61pSt72KxxOnnV_Oj4OTAiKYCSTek0Pm87hVDod4Bg@mail.gmail.com>
 <CAA4eK1Lmd-stXWrNqX9iXugjY=ahhe7zRfyq+-vN512xvF4G2w@mail.gmail.com>
 <CAPpHfdsTiYQPywr4yeqVhUtA+eFdqisqcAOiTb+kiYhi9EVEvw@mail.gmail.com>
 <CAPpHfdvk-nfu5xzJyPArxWctofWPR+1L9uJ+yyWFA34n6b5rGQ@mail.gmail.com>
 <CAA4eK1Ladnm40UO-YC+c7eBYqjyFQSwg0dn1w_CiaMoBTsJUDA@mail.gmail.com>
 <CAPpHfduX--KKX853UwaJ8Cjo5bxbh19V_+McKQ3p9aS6b8T1Wg@mail.gmail.com>
 <CAA4eK1+VbBxYY-rG4B7Jq6TsYvdjt3d2nbUrs7p9-1sP5mH+sw@mail.gmail.com>
 <CAPpHfdvxqjE+RZdoOODQZAmQip6NpvSH40DuvVFWuf_00ek-yQ@mail.gmail.com>
 <1d97ec-6841b600-3-b7b4780@40747246>
 <CAA4eK1LvssAcp61qg957xRF0=K4xF0hfJQjQ6c9V7EGHSqraPg@mail.gmail.com>
 <28c8bf-68470780-3-51b29480@89454035>
 <CAPpHfdt77k3BqD=anh4b7UiRevfPOu2Hcf3rvSZXntxH+4G=Ug@mail.gmail.com>
 <fbc5d94e-6fbd-4a64-85d4-c9e284a58eb2@gmail.com>
 <CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng@mail.gmail.com>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: 
 <CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/0a617d34-abc3-4090-92a5-ea15d45e36f6%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------u0PuCafMjfjF03rASxGZfHSZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

15.06.2025 14:02, Alexander Korotkov wrote:
> Could you, please, check this patch?  On my system it makes 046 and
> 047 execute in 140 secs with -O0 and -DRELCACHE_FORCE_RELEASE
> -DCATCACHE_FORCE_RELEASE.

Thank you for the patch!

It decreases the test's duration significantly:
# +++ tap check in src/test/recovery +++
t/046_checkpoint_logical_slot.pl .. ok
All tests successful.
Files=1, Tests=1, 29 wallclock secs ( 0.01 usr  0.00 sys +  0.23 cusr  0.56 csys =  0.80 CPU)

Without the patch:
t/046_checkpoint_logical_slot.pl .. ok
All tests successful.
Files=1, Tests=1, 519 wallclock secs ( 0.01 usr  0.00 sys +  3.05 cusr  7.64 csys = 10.70 CPU)
Result: PASS

Best regards,
Alexander
--------------u0PuCafMjfjF03rASxGZfHSZ
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">15.06.2025 14:02, Alexander Korotkov
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAPpHfdvPpg5VUTNOqfKSNx66ij3ZJNZbf4kn6SDcPkdq9FTvng@mail.gmail.com">
      <pre wrap="" class="moz-quote-pre">
Could you, please, check this patch?  On my system it makes 046 and
047 execute in 140 secs with -O0 and -DRELCACHE_FORCE_RELEASE
-DCATCACHE_FORCE_RELEASE.
</pre>
    </blockquote>
    <br>
    Thank you for the patch!<br>
    <br>
    It decreases the test's duration significantly:<br>
    # +++ tap check in src/test/recovery +++<br>
    t/046_checkpoint_logical_slot.pl .. ok<br>
    All tests successful.<br>
    Files=1, Tests=1, 29 wallclock secs ( 0.01 usr  0.00 sys +  0.23
    cusr  0.56 csys =  0.80 CPU)<br>
    <br>
    Without the patch:<br>
    t/046_checkpoint_logical_slot.pl .. ok<br>
    All tests successful.<br>
    Files=1, Tests=1, 519 wallclock secs ( 0.01 usr  0.00 sys +  3.05
    cusr  7.64 csys = 10.70 CPU)<br>
    Result: PASS<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------u0PuCafMjfjF03rASxGZfHSZ--