Feedback-ID: i131946ab:Fastmail
Message-ID: <0ad3543a-40d9-17f9-794f-75ea0106544a@enterprisedb.com>
Date: Thu, 9 Mar 2023 10:36:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: Move defaults toward ICU in 16?
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Andres Freund <andres@anarazel.de>,
 Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
References: <5ffeafe843d43a975f31479fbd211ab88404841b.camel@j-davis.com>
 <20230211020042.uthdgj72kp3xlqam@awork3.anarazel.de>
 <d47923e2774cb5e5b6207f8678ffcc11bd110c4a.camel@j-davis.com>
 <20230214175957.idkb7shsqzp5nbll@awork3.anarazel.de>
 <e4387c6959c9ed0d6dc9f14e01ff191f3e1a30c0.camel@j-davis.com>
 <2a7feb71dbdcea31478b3974b8075982ac2326d2.camel@j-davis.com>
 <20230217170523.ujnq3qr75rolfrmu@awork3.anarazel.de>
 <c412488b2a19467e4c037ad02db5d91431bdf178.camel@j-davis.com>
 <20230217180909.oqxjgjudbsofn666@awork3.anarazel.de>
 <3bf6b5517033947c134ed1ba9a325179a608bfd1.camel@j-davis.com>
 <20230217205009.4sy4lmmqanbhjsgb@awork3.anarazel.de>
 <558f794c351fb73596e4b05d96f66d01d56b4a50.camel@j-davis.com>
 <f2b896d1476915862b99c2514c298c052e048c57.camel@j-davis.com>
 <d62b2874-729b-d26a-2d0a-0d64f509eca4@enterprisedb.com>
 <438b15cf88c9c5cf0cf1c24bf7b835d6362a8e0c.camel@j-davis.com>
 <10bb0e53ba16e5865ea4d37575ee15d4df5dc043.camel@j-davis.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <10bb0e53ba16e5865ea4d37575ee15d4df5dc043.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/0ad3543a-40d9-17f9-794f-75ea0106544a%40enterprisedb.com>
Precedence: bulk

On 08.03.23 06:55, Jeff Davis wrote:
> On Fri, 2023-03-03 at 21:45 -0800, Jeff Davis wrote:
>>>>     0002: update template0 in new cluster (as described above)
> 
> I think 0002 is about ready and I plan to commit it soon unless someone
> has more comments.

0002 seems fine to me.

> I'm holding off on 0001 for now, because you objected. But I still
> think 0001 is a good idea so I'd like to hear more before I withdraw
> it.

Let's come back to that after dealing with the other two.

>>>>     0003: default initdb to use ICU
> 
> This is also about ready, and I plan to commit this soon after 0002.

This seems mostly ok to me.  I have a few small comments.

+        default, ICU obtains the ICU locale from the ICU default collator.

This seems to be a fancy way of saying, the default ICU locale will be 
set to something that approximates what you have set your operating 
system to.  Which is what we want, I think.  Can we say this in a more 
user-friendly way?

+static void
+check_icu_locale()

should be check_icu_locale(void)

+       if (U_ICU_VERSION_MAJOR_NUM >= 54)
+       {

If we're going to add more of these mysterious version checks, could we 
add a comment about what they are for?

However, I suspect what this chunk is doing is some sort of 
canonicalization/language-tag conversion, which per the other thread, I 
have some questions about.

How about for this patch, we skip this part and just do the else branch

+           icu_locale = pg_strdup(default_locale);

and then put the canonicalization business into the canonicalization 
patch set?