Message-ID: <0b00a6ff-1475-c0ba-15ec-5b5e381c6359@dunslane.net>
Date: Wed, 23 Nov 2022 14:56:28 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Stephen Frost <sfrost@snowman.net>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <20220930223257.GA190214@nathanxps13>
 <749976.1664579138@sss.pgh.pa.us> <20220930231834.GA366260@nathanxps13>
 <CADkLM=fg15_SYRGBcTFpoW-vVUTCkLfe+NTM0G32RjWY1W5Pvw@mail.gmail.com>
 <20221114234004.GA1771874@nathanxps13> <20221115050813.GA1953731@nathanxps13>
 <287b17b8-92f3-2bc2-6bcf-31dc1305b65a@dunslane.net>
 <20221117043952.GA116054@nathanxps13> <20221118170504.GA401589@nathanxps13>
 <20221119185004.GA539143@nathanxps13> <20221120165713.GA597801@nathanxps13>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <20221120165713.GA597801@nathanxps13>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/0b00a6ff-1475-c0ba-15ec-5b5e381c6359%40dunslane.net>
Precedence: bulk


On 2022-11-20 Su 11:57, Nathan Bossart wrote:
> On Sat, Nov 19, 2022 at 10:50:04AM -0800, Nathan Bossart wrote:
>> another rebase
> Another rebase for cfbot.
>


I have committed the first couple of these to get them out of the way.

But I think we need a bit of cleanup in the next patch.
vacuum_is_relation_owner() looks like it's now rather misnamed. Maybe
vacuum_is_permitted_for_relation()? Also I think we need a more thorough
reworking of the comments around line 566. And I think we need a more
detailed explanation of why the change in vacuum_rel is ok, and if it is
OK we should adjust the head comment on the function.

In any case I think this comment would be better English with "might"
instead of "may":

/* user may have the ANALYZE privilege */


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com