Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940
MIME-Version: 1.0
Message-Id: <0b0b5d11-2b10-493f-b9fd-649c6b9bdcd4@app.fastmail.com>
In-Reply-To: <2abb05b6-9173-45a7-a5dc-0f4cf2a4c7f4@eisentraut.org>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <CALDaNm2ev8_r4N5Sfa2GjzuzZNz17L0nsX_ZqfcarmS5oa5Szw@mail.gmail.com>
 <TYCPR01MB12077CD333376B53F9CAE7AC0F5562@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e390e35e-508e-4eb8-92e4-e6b066407a41@app.fastmail.com>
 <TYCPR01MB12077121263EFF7680486B635F5212@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <40595e73-c7e1-463a-b8be-49792e870007@app.fastmail.com>
 <6423dfeb-a729-45d3-b71e-7bf1b3adb0c9@enterprisedb.com>
 <TYCPR01MB12077DE77454D68E959E85E35F5272@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e8564096-3c4f-4990-ac7d-ba089739b878@app.fastmail.com>
 <CANhcyEW6-dH28gLbFc5XpDTJ6JPizU+t5g-aKUWJBf5W_Zriqw@mail.gmail.com>
 <2f0b73f3-e7c0-4e95-9712-1993442a6b64@app.fastmail.com>
 <CAA4eK1JtnzqYNQ_S+mj_XsPfgk7szxegKiVQq4-8fY1wUcUnpg@mail.gmail.com>
 <34637e7f-0330-420d-8f45-1d022962d2fe@app.fastmail.com>
 <CANhcyEWXGGzPGUxF-pVd6Xnqi_o4WyB8KQW=1fjHStvy97ma3g@mail.gmail.com>
 <2abb05b6-9173-45a7-a5dc-0f4cf2a4c7f4@eisentraut.org>
Date: Thu, 21 Mar 2024 01:56:11 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Peter Eisentraut" <peter@eisentraut.org>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>
Cc: "Amit Kapila" <amit.kapila16@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "Michael Paquier" <michael@paquier.xyz>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>,
 "vignesh C" <vignesh21@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/alternative;
 boundary=a9710c8365df4f17821c591f5a44dc70
Archived-At: <https://www.postgresql.org/message-id/0b0b5d11-2b10-493f-b9fd-649c6b9bdcd4%40app.fastmail.com>
Precedence: bulk

--a9710c8365df4f17821c591f5a44dc70
Content-Type: text/plain

On Tue, Mar 19, 2024, at 8:57 AM, Peter Eisentraut wrote:
> On 19.03.24 12:26, Shlok Kyal wrote:
> > 
> > I have added a top-up patch v30-0003. The issue in [1] still exists in
> > the v30 patch. I was not able to come up with an approach to handle it
> > in the code, so I have added it to the documentation in the warning
> > section. Thoughts?
> 
> Seems acceptable to me.  pg_createsubscriber will probably always have 
> some restrictions and unsupported edge cases like that.  We can't 
> support everything, so documenting is ok.

Shlok, I'm not sure we should add a sentence about a pilot error. I added a
comment in check_subscriber that describes this situation. I think the comment
is sufficient to understand the limitation and, if it is possible in the future,
a check might be added for it. I didn't include v31-0004.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--a9710c8365df4f17821c591f5a44dc70
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Tue, Mar 19,=
 2024, at 8:57 AM, Peter Eisentraut wrote:<br></div><blockquote type=3D"=
cite" id=3D"qt" style=3D""><div>On 19.03.24 12:26, Shlok Kyal wrote:<br>=
</div><div>&gt;&nbsp;<br></div><div>&gt; I have added a top-up patch v30=
-0003. The issue in [1] still exists in<br></div><div>&gt; the v30 patch=
. I was not able to come up with an approach to handle it<br></div><div>=
&gt; in the code, so I have added it to the documentation in the warning=
<br></div><div>&gt; section. Thoughts?<br></div><div><br></div><div>Seem=
s acceptable to me.&nbsp; pg_createsubscriber will probably always have&=
nbsp;<br></div><div>some restrictions and unsupported edge cases like th=
at.&nbsp; We can't&nbsp;<br></div><div>support everything, so documentin=
g is ok.<br></div></blockquote><div><br></div><div>Shlok, I'm not sure w=
e should add a sentence about a pilot error. I added a<br></div><div>com=
ment in check_subscriber that describes this situation. I think the comm=
ent<br></div><div>is sufficient to understand the limitation and, if it =
is possible in the future,<br></div><div>a check might be added for it. =
I didn't include v31-0004.<br></div><div><br></div><div><br></div><div i=
d=3D"sig112409080"><div class=3D"signature">--<br></div><div class=3D"si=
gnature">Euler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nbsp;=
 <a href=3D"https://www.enterprisedb.com/">https://www.enterprisedb.com/=
</a><br></div></div><div><br></div></body></html>
--a9710c8365df4f17821c591f5a44dc70--