Message-ID: <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
Date: Tue, 4 Jul 2023 09:34:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: Autogenerate some wait events code and documentation
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <124bdcea-bdc8-e3d2-2357-0c6a857bc557@gmail.com>
 <ZFW6FTMIH00502RU@paquier.xyz> <ZFW9UYQFyftKpoaH@paquier.xyz>
 <106e8d0a-0820-687a-7da5-3143e1f5b05b@gmail.com>
 <ZGM1U5D5EuBUbasi@paquier.xyz>
 <976f4eb1-cbc0-9616-ec26-ebb4a252315c@gmail.com>
 <ZGSM8oOpXsXrXy/v@paquier.xyz>
 <69588eaf-02d7-95a8-0da4-3e120de16a59@gmail.com>
 <ZGWrTn//v+WAqMpN@paquier.xyz> <ZKJxZrnFTxoCx8a5@paquier.xyz>
 <ZKJ0tzXSH1LyqI9V@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZKJ0tzXSH1LyqI9V@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/0b3cdac7-f078-61a6-76e0-99db7aae78ce%40gmail.com>
Precedence: bulk

Hi,

On 7/3/23 9:11 AM, Michael Paquier wrote:
> On Mon, Jul 03, 2023 at 03:57:42PM +0900, Michael Paquier wrote:

Thanks for looking at it and having fixed the issues that were present in
v10.

>> I think that we should add some options to the perl script to be more
>> selective with the files generated.  How about having two options
>> called --docs and --code to select one or the other, then limit what
>> gets generated in each path?  I guess that it would be cleaner if we
>> error in the case where both options are defined, and just use some
>> gotos to redirect to each foreach loop to limit extra indentations in
>> the script.  This would avoid the need to remove the C and H files
>> from the docs, additionally, which is what the Makefile in doc/ does.
>>
>> I have fixed all the issues I've found in v11 attached, except for the
>> last one (I have added the OUTDIR trick for reference, but that's
>> incorrect and incomplete).  Could you look at this part?
> 
> Ah.  It took me a few extra minutes, but I think that we should set
> "capture" to "false", no?  It looks like meson is getting confused,
> expecting something in stdout but the new script generates a few
> files, and does not output anything.  That's different from the other
> doc-related perl scripts.
> --

Yeah, with "capture" set to "false" then ninja alldocs does not error out
and wait_event_types.sgml gets generated.

I'll look at the extra options --code and --docs.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com