Message-ID: <0b8303b1-3251-4559-8ab3-5bb5c8271d3b@proxel.se>
Date: Fri, 1 May 2026 09:39:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables
 with dropped identity columns
From: Andreas Karlsson <andreas@proxel.se>
To: William Bernbaum <wbernbaum@dwdev.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <PH0PR18MB44430C10F7431F8D163CDAFFA6202@PH0PR18MB4443.namprd18.prod.outlook.com>
 <49471fc0-5f07-4ed4-b33c-fc634aa301ef@proxel.se>
Content-Language: en-US
In-Reply-To: <49471fc0-5f07-4ed4-b33c-fc634aa301ef@proxel.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/0b8303b1-3251-4559-8ab3-5bb5c8271d3b%40proxel.se>
Precedence: bulk

On 5/1/26 09:28, Andreas Karlsson wrote:
> On 4/18/26 01:29, William Bernbaum wrote:
>> Patch attached.

Forgot this: Maybe it is just a bit too early in the morning and I have 
not had coffee yet but I struggled a bit to apply your patch. A 
recommendation for making patches easy to apply for other developers is 
to generate them with the "git format-patch" command which makes them 
easy to apply with "git am". You can use the "-v" flag to "git 
format-patch" if you want to add a version number to the generated file 
names.
Also another question worth looking into is if this same bug affects 
other things, e.g. the setting of hasdefaults.

Thanks again for the patch!

--
Andreas Karlsson
Percona