Message-ID: <0befffb3-8323-f2cd-915f-0ab64396f500@amazon.com>
Date: Thu, 11 Aug 2022 08:11:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.1
Subject: Re: shared-memory based stats collector - v70
Content-Language: en-US
To: Greg Stark <stark@mit.edu>
CC: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Melanie
 Plageman <melanieplageman@gmail.com>, Kyotaro Horiguchi
	<horikyota.ntt@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Thomas Munro
	<thomas.munro@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20220317073652.kz3uuh6le6vbfod4@alap3.anarazel.de>
 <20220325.142256.1649716600998659084.horikyota.ntt@gmail.com>
 <20220325.172418.1055357550509939415.horikyota.ntt@gmail.com>
 <20220402082102.ojdd2e6cobsmljvh@alap3.anarazel.de>
 <20220404041516.cctrvpadhuriawlq@alap3.anarazel.de>
 <20220405030506.lfdhbu5zf4tzdpux@alap3.anarazel.de>
 <20220406030008.2qxipjxo776dwnqs@alap3.anarazel.de>
 <CAM-w4HN=4ss5dS2DH6Cof=zocJXeGOjRNKxEGgUZdJPMndyNzA@mail.gmail.com>
 <CAAKRu_Z18jYbarKA4GZMOO00KtUqKtBqgQ8SgB=wSvSqKq3iiA@mail.gmail.com>
 <1736122.1658333315@sss.pgh.pa.us>
 <CAM-w4HOxaO6iJ94bGt1A65PRgX_b4gGSmb4mdzakZ1QhvGW=jA@mail.gmail.com>
 <83D73EC0-E3ED-4C98-A528-5E122278D553@anarazel.de>
 <CAM-w4HMhHAxjpXNVMZ5WhULHpd3+LuP27zaSKSFnzZeRwHZTjg@mail.gmail.com>
 <caa515eb-e9e7-9fe7-ceb1-a96b6f3787ce@amazon.com>
 <CAM-w4HNqCR7X9q5_wbJi4wLfTT1gLvy5VRS+ZGo6z8-DbXkHpw@mail.gmail.com>
 <5db2b670-f3df-57ea-bdc6-962a582ff2e4@amazon.com>
 <CAM-w4HP_YL8uPrNiv2DPKmq1KD3QLEX7CBLc5DCJ9j7mf7eerw@mail.gmail.com>
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: 
 <CAM-w4HP_YL8uPrNiv2DPKmq1KD3QLEX7CBLc5DCJ9j7mf7eerw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/0befffb3-8323-f2cd-915f-0ab64396f500%40amazon.com>
Precedence: bulk

Hi,

On 8/10/22 11:25 PM, Greg Stark wrote:
> On Wed, 10 Aug 2022 at 04:05, Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>> Hi,
>>
>> On 8/9/22 6:00 PM, Greg Stark wrote:
>>> On Tue, 9 Aug 2022 at 06:19, Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>>>> What do you think about adding a function in core PG to provide such
>>>> functionality? (means being able to retrieve all the stats (+ eventually
>>>> add some filtering) without the need to connect to each database).
>>> I'm working on it myself too. I'll post a patch for discussion in a bit.
>> Great! Thank you!
> So I was adding the code to pgstat.c because I had thought there were
> some data types I needed and/or static functions I needed. However you
> and Andres encouraged me to check again now. And indeed I was able,
> after fixing a couple things, to make the code work entirely
> externally.

Nice!

Though I still think to have an SQL API in core could be useful to.

As Andres was not -1 about that idea (as it should be low cost to add 
and maintain) as long as somebody cares enough to write something: then 
I'll give it a try and submit a patch for it.

>
> This is definitely not polished and there's a couple obvious things
> missing. But at the risk of embarrassment I've attached my WIP. Please
> be gentle :) I'll post the github link in a bit when I've fixed up
> some meta info.

Thanks! I will have a look at it on github (once you share the link).

Regards,

-- 
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com