Date: Mon, 16 Jan 2023 14:57:55 +0800
From: Zhang Mingli <zmlpostgres@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <0c92fbb5-b42a-4b80-824f-74220a185a81@Spark>
In-Reply-To: <20230115161054.GA2582058@nathanxps13>
References: <a4455bce-dd71-4f4d-875c-4017fd8e7883@Spark>
 <49bebf7a-059a-4750-ba30-3fe0a734e4e9@Spark>
 <959c08bb-3b3d-4143-b247-86527d5e5cc4@Spark>
 <20230115161054.GA2582058@nathanxps13>
Subject: Re: Code review in dsa.c
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="63c4f578_60ef0119_17004"
Archived-At: <https://www.postgresql.org/message-id/0c92fbb5-b42a-4b80-824f-74220a185a81%40Spark>
Precedence: bulk

--63c4f578_60ef0119_17004
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

HI,

On Jan 16, 2023, 00:10 +0800, Nathan Bossart <nathandbossart@gmail.com>, wrote:
> On Mon, Jan 16, 2023 at 12:04:56AM +0800, Zhang Mingli wrote:
> > So, they are all dead codes, provide a patch to remove them.
>
> I am proposing a new use of dsa_create, dsa_attach, and dsa_get_handle in
> https://commitfest.postgresql.org/41/4020/. These might also be useful for
> extensions, so IMHO we should keep this stuff.
>
> --
> Nathan Bossart
> Amazon Web Services: https://aws.amazon.com
OK, thanks.

Regards,
Zhang Mingli

--63c4f578_60ef0119_17004
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<html xmlns=3D=22http://www.w3.org/1999/xhtml=22>
<head>
<title></title>
</head>
<body>
<div name=3D=22messageBodySection=22>
<div dir=3D=22auto=22>HI,<br />
<br />
On Jan 16, 2023, 00:10 +0800, Nathan Bossart &lt;nathandbossart=40gmail.c=
om&gt;, wrote:</div>
<blockquote style=3D=22border-left-color: rgb(26, 188, 156); margin: 5px;=
 padding-left: 10px; border-left-width: thin; border-left-style: solid;=22=
>On Mon, Jan 16, 2023 at 12:04:56AM +0800, Zhang Mingli wrote:<br />
<blockquote style=3D=22border-left-color: rgb(230, 126, 34); margin: 5px;=
 padding-left: 10px; border-left-width: thin; border-left-style: solid;=22=
>So, they are all dead codes, provide a patch to remove them.</blockquote=
>
<br />
I am proposing a new use of dsa=5Fcreate, dsa=5Fattach, and dsa=5Fget=5Fh=
andle in<br />
https://commitfest.postgresql.org/41/4020/. These might also be useful fo=
r<br />
extensions, so IMHO we should keep this stuff.<br />
<br />
--<br />
Nathan Bossart<br />
Amazon Web Services: https://aws.amazon.com</blockquote>
<div dir=3D=22auto=22>OK, thanks.</div>
</div>
<div name=3D=22messageSignatureSection=22><br />
<div dir=3D=22auto=22><span style=3D=22color: var(--textColor); backgroun=
d-color: var(--backgroundColor);=22>Regards,</span><br /></div>
<div dir=3D=22auto=22>Zhang Mingli</div>
</div>
</body>
</html>

--63c4f578_60ef0119_17004--