Subject: Re: refactoring basebackup.c
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Mark Dilger <mark.dilger@enterprisedb.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: 
 <CA+TgmoZGwR=ZVWFeecncubEyPdwghnvfkkdBe9BLccLSiqdf9Q@mail.gmail.com>
 <CA+TgmoZBqs7KkyBUFzXQaztuonKanuOV+f_7DYsHOpJs=0B2DA@mail.gmail.com>
 <CA+TgmoY5zpS=gJj2O0PXi6YGao5YR89v0qN_xZzWNvff2Tug+Q@mail.gmail.com>
 <58D2BD01-B541-4032-9C0B-B6143841E7ED@enterprisedb.com>
 <CA+TgmoYgVN=-Yoh71r3P9N7eKysd7_9b9s+1QFfFcs3w7Z-tig@mail.gmail.com>
 <4799332e-61ae-3a08-c5da-38f61fa0493d@enterprisedb.com>
 <CAFiTN-uhg4iKA7FGWxaG9J8WD_LTx655+AUW3_KiK1=SakQy4A@mail.gmail.com>
 <1cee30a1-b7db-41fa-7ec7-4e2750e5132d@enterprisedb.com>
 <CAFiTN-vnnnQ_2HwmZu=8ZO47e_J1aX5Ngnv4whBMsFwd_WG2rQ@mail.gmail.com>
From: tushar <tushar.ahuja@enterprisedb.com>
Message-ID: <0caaf88d-18c0-943a-d7ab-ac0fd5b05dc3@enterprisedb.com>
Date: Thu, 22 Jul 2021 22:44:31 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: 
 <CAFiTN-vnnnQ_2HwmZu=8ZO47e_J1aX5Ngnv4whBMsFwd_WG2rQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/0caaf88d-18c0-943a-d7ab-ac0fd5b05dc3%40enterprisedb.com>
Precedence: bulk

On 7/19/21 8:29 PM, Dilip Kumar wrote:
> I am not sure why this is working, from the code I could not find if
> the backup target is server then are we doing anything with the -R
> option or we are just silently ignoring it

OK, in an  another scenario  I can see , "-t server" working with 
"--server-compression" option  but not with -z  or -Z ?

"-t  server" with option "-z"  / or (-Z )

[tushar@localhost bin]$ ./pg_basebackup -t server:/tmp/dataN -Xnone  -z  
--no-manifest -p 9033
pg_basebackup: error: only tar mode backups can be compressed
Try "pg_basebackup --help" for more information.

tushar@localhost bin]$ ./pg_basebackup -t server:/tmp/dataNa -Z 1    
-Xnone  --server-compression=gzip4  --no-manifest -p 9033
pg_basebackup: error: only tar mode backups can be compressed
Try "pg_basebackup --help" for more information.

"-t server" with "server-compression"  (working)

[tushar@localhost bin]$ ./pg_basebackup -t server:/tmp/dataN -Xnone  
--server-compression=gzip4  --no-manifest -p 9033
NOTICE:  WAL archiving is not enabled; you must ensure that all required 
WAL segments are copied through other means to complete the backup
[tushar@localhost bin]$

-- 
regards,tushar
EnterpriseDB  https://www.enterprisedb.com/
The Enterprise PostgreSQL Company