Content-Type: multipart/mixed; boundary="------------3ShDvkc5IIPiKJn1zOpcqCYr"
Message-ID: <0cbf5d34-f117-456f-bcc0-50fa9a8eafba@gmail.com>
Date: Tue, 3 Feb 2026 16:05:40 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Propagate XLogFindNextRecord error to callers
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <CAO6_XqoxJXddcT4wkd9Xd+cD6Sz-fyspRGuV4Bq-wbXG4pVNzA@mail.gmail.com>
Content-Language: en-GB
From: Mircea Cadariu <cadariu.mircea@gmail.com>
In-Reply-To: <CAO6_XqoxJXddcT4wkd9Xd+cD6Sz-fyspRGuV4Bq-wbXG4pVNzA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/0cbf5d34-f117-456f-bcc0-50fa9a8eafba%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------3ShDvkc5IIPiKJn1zOpcqCYr
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Anthonin,

On 12/12/2025 10:39, Anthonin Bonnefoy wrote:
>
> With this patch, pg_waldump will now have the following output when 
> reading a file with an invalid header:
> pg_waldump: error: could not find a valid record after D80/5C000000: 
> invalid magic number D116 in WAL segment 0000001400000D8000000017, LSN 
> D80/5C000000, offset 0

I've picked up the review for your patch.

Attached is a failing test that reproduces the issue. Have I got it 
right? We can consider using it to validate your patch then.

-- 
Thanks,
Mircea Cadariu

--------------3ShDvkc5IIPiKJn1zOpcqCYr
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-Add-pg_waldump-test-for-invalid-WAL-page-magic-er.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-Add-pg_waldump-test-for-invalid-WAL-page-magic-er.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA1NmY1YTI1MTIyNzVmMmJjMTA4NmQ4NDZhYThkNjNiOGQ3MTY2Y2EwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaXJjZWEgQ2FkYXJpdSA8Y2FkYXJpdS5taXJjZWFA
Z21haWwuY29tPgpEYXRlOiBUdWUsIDMgRmViIDIwMjYgMTU6NDk6MjYgKzAwMDAKU3ViamVj
dDogW1BBVENIIHYxXSBBZGQgcGdfd2FsZHVtcCB0ZXN0IGZvciBpbnZhbGlkIFdBTCBwYWdl
IG1hZ2ljIGVycm9yCiBtZXNzYWdlCgotLS0KIHNyYy9iaW4vcGdfd2FsZHVtcC90LzAwM19l
cnJvcl9tZXNzYWdlLnBsIHwgMjIgKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNo
YW5nZWQsIDIyIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBzcmMvYmluL3Bn
X3dhbGR1bXAvdC8wMDNfZXJyb3JfbWVzc2FnZS5wbAoKZGlmZiAtLWdpdCBhL3NyYy9iaW4v
cGdfd2FsZHVtcC90LzAwM19lcnJvcl9tZXNzYWdlLnBsIGIvc3JjL2Jpbi9wZ193YWxkdW1w
L3QvMDAzX2Vycm9yX21lc3NhZ2UucGwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw
MDAwMDAwMC4uNzk5MmQxOGYxYgotLS0gL2Rldi9udWxsCisrKyBiL3NyYy9iaW4vcGdfd2Fs
ZHVtcC90LzAwM19lcnJvcl9tZXNzYWdlLnBsCkBAIC0wLDAgKzEsMjIgQEAKK3VzZSBzdHJp
Y3Q7Cit1c2Ugd2FybmluZ3MgRkFUQUwgPT4gJ2FsbCc7Cit1c2UgUG9zdGdyZVNRTDo6VGVz
dDo6VXRpbHM7Cit1c2UgVGVzdDo6TW9yZTsKKworbXkgJHRlbXBkaXIgPSBQb3N0Z3JlU1FM
OjpUZXN0OjpVdGlsczo6dGVtcGRpcigpOworbXkgJHdhbGZpbGUgPSAiJHRlbXBkaXIvMDAw
MDAwMDEwMDAwMDAwMDAwMDAwMDAwIjsKKworb3BlbihteSAkZmgsICc+JywgJHdhbGZpbGUp
IG9yIGRpZSAiQ2Fubm90IGNyZWF0ZSAkd2FsZmlsZTogJCEiOworYmlubW9kZSgkZmgpOwor
cHJpbnQgJGZoIHBhY2soJ3Z2VlE8VlZRPFZWJywKKyAgICAweEQxMTYsIDB4MDAwMiwgMSwg
MCwgMCwgMCwgMTIzNDU2Nzg5MDEyMzQsIDE2KjEwMjQqMTAyNCwgODE5Mik7CitwcmludCAk
ZmggIlwwIiB4ICg4MTkyIC0gNDApOworY2xvc2UoJGZoKTsKKworY29tbWFuZF9mYWlsc19s
aWtlKAorICAgIFsgJ3BnX3dhbGR1bXAnLCAnLS1zdGFydD0wLzI4JywgJHdhbGZpbGUgXSwK
KyAgICBxci9pbnZhbGlkIG1hZ2ljIG51bWJlci4qRDExNi9pLAorICAgICdkZXRhaWxlZCBl
cnJvciBtZXNzYWdlIHNob3duIGZvciBpbnZhbGlkIFdBTCBwYWdlIG1hZ2ljJworKTsKKwor
ZG9uZV90ZXN0aW5nKCk7Ci0tIAoyLjM5LjUgKEFwcGxlIEdpdC0xNTQpCgo=

--------------3ShDvkc5IIPiKJn1zOpcqCYr--