Message-ID: <0d23e027-02dd-4533-7ac7-b5da972a5736@gmail.com>
Date: Wed, 8 Feb 2023 14:48:24 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: meson: Non-feature feature options
Content-Language: en-US
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ad65ffd1-a9a7-fda1-59c6-f7dc763c3051@enterprisedb.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
In-Reply-To: <ad65ffd1-a9a7-fda1-59c6-f7dc763c3051@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/0d23e027-02dd-4533-7ac7-b5da972a5736%40gmail.com>
Precedence: bulk

Hi,


On 2/8/23 13:45, Peter Eisentraut wrote:
>
> The problem is that these features now cannot be automatically enabled 
> and behave annoyingly different from other feature options.

Agreed.


> For the 'ssl' option, we have deprecated the --with-openssl option in 
> configure and replaced it with --with-ssl, in anticipation of other 
> SSL implementations.  None of that ever happened or is currently 
> planned AFAICT.  So I suggest that we semi-revert this, so that we can 
> make 'openssl' an auto option in meson.

+1


> For the 'uuid' option, I'm not sure what the best way to address this 
> would.  We could establish a search order of libraries that is used if 
> no specific one is set (similar to libreadline, libedit, in a way).  
> So we'd have one option 'uuid' that is of type feature with default 
> 'auto' and another option, say, 'uuid-library' of type 'combo'.
>

Your suggestion looks good and TCL already has a similar implementation 
with what you suggested:

option('pltcl', type : 'feature', value: 'auto',
   description: 'build with TCL support')

option('tcl_version', type : 'string', value : 'tcl',
   description: 'specify TCL version')


Regards,
Nazir Bilal Yavuz
Microsoft