Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGUhr-0001Md-OH for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Dec 2016 17:48:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cGUhr-00039i-BC for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Dec 2016 17:48:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cGUhi-00031U-G1; Mon, 12 Dec 2016 17:47:58 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGUhf-0004vb-Fl; Mon, 12 Dec 2016 17:47:57 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 6CA3C21C5676; Mon, 12 Dec 2016 20:47:54 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Received: from mail.postgrespro.ru ([127.0.0.1]) by localhost (mail.postgrespro.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tQsBqgOfGR-z; Mon, 12 Dec 2016 20:47:54 +0300 (MSK) Received: from localhost (unknown [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTPSA id AC50E21C5667; Mon, 12 Dec 2016 20:47:53 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1481564873; bh=dH12F+Awn4ZHSiG10RX28o5hkdMEtqy8HFWrg+Ef85M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kZGAT8GOtsZJ0JJly60+Rd26r7ar8FMtwQATNGMdGdSysNY9Q4FWX4QZGHFA39DXm /d34z8e1E/8frZzSQIPT0NzJSMp1WEq4W6kdT58BDEIhbf4fWE6qO9VRkCymIcwsap 8Po8wJGnOg/ijUPVmGrB1sD0deX2ZAbbRMN9N5P0= From: Dmitry Ivanov To: Dmitry Ivanov Cc: Robert Haas , Michael Paquier , Andres Freund , Erik Rijkers , Amit Langote , Amit Langote , Rajkumar Raghuwanshi , Ashutosh Bapat , Pg Hackers , Subject: Re: Declarative partitioning - another take Date: Mon, 12 Dec 2016 20:45:38 +0300 MIME-Version: 1.0 Message-ID: <0d5b64c9-fa05-4dab-93e7-56576d1193ca@postgrespro.ru> In-Reply-To: References: <890ce68d-2cff-ccf3-67f7-6f5d3264dbfc@lab.ntt.co.jp> <78ae9888-7372-245d-cf6b-f655e6fe6c12@lab.ntt.co.jp> <20161208043942.ekjvyf7ddbxehh7c@alap3.anarazel.de> <426b2b01-61e0-43aa-bd84-c6fcf516f1c3@postgrespro.ru> Organization: Postgres Professional User-Agent: Trojita/0.7; Qt/5.7.0; xcb; Linux; Content-Type: multipart/mixed; boundary="trojita=_ed660bf7-1094-4797-9d30-17a5ba0a6a31" X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multipart/mixed message in MIME format. --trojita=_ed660bf7-1094-4797-9d30-17a5ba0a6a31 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Huh, this code is broken as well. We have to ignore partitions that don't=20 have any subpartitions. Patch is attached below (v2). --=20 Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Company= --trojita=_ed660bf7-1094-4797-9d30-17a5ba0a6a31 Content-Type: text/x-patch Content-Disposition: attachment; filename=hacky_partitioning_hotfix_v2.diff Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvcGFydGl0aW9uLmMg Yi9zcmMvYmFja2VuZC9jYXRhbG9nL3BhcnRpdGlvbi5jCmluZGV4IDIxOWQz ODAuLjY1NTVjN2MgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NhdGFsb2cv cGFydGl0aW9uLmMKKysrIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9wYXJ0aXRp b24uYwpAQCAtOTUwLDcgKzk1MCw4IEBAIFJlbGF0aW9uR2V0UGFydGl0aW9u RGlzcGF0Y2hJbmZvKFJlbGF0aW9uIHJlbCwgaW50IGxvY2ttb2RlLAogCQkJ ICAgKnBhcnRlZF9yZWxzOwogCUxpc3RDZWxsICAgKmxjOwogCWludAkJCWks Ci0JCQkJazsKKwkJCQlrLAorCQkJCXBhcnRpdGlvbmVkX2NoaWxkcmVuX3Nv X2ZhciA9IDA7CiAKIAkvKgogCSAqIExvY2sgcGFydGl0aW9ucyBhbmQgbWFr ZSBhIGxpc3Qgb2YgdGhlIHBhcnRpdGlvbmVkIG9uZXMgdG8gcHJlcGFyZQpA QCAtMTAwMSw3ICsxMDAyLDcgQEAgUmVsYXRpb25HZXRQYXJ0aXRpb25EaXNw YXRjaEluZm8oUmVsYXRpb24gcmVsLCBpbnQgbG9ja21vZGUsCiAJCVBhcnRp dGlvbktleSBwYXJ0a2V5ID0gUmVsYXRpb25HZXRQYXJ0aXRpb25LZXkocGFy dHJlbCk7CiAJCVBhcnRpdGlvbkRlc2MgcGFydGRlc2MgPSBSZWxhdGlvbkdl dFBhcnRpdGlvbkRlc2MocGFydHJlbCk7CiAJCWludAkJCWosCi0JCQkJCW07 CisJCQkJCW15X3BhcnRpdGlvbmVkX2NoaWxkcmVuOwogCiAJCXBkW2ldID0g KFBhcnRpdGlvbkRpc3BhdGNoKSBwYWxsb2Moc2l6ZW9mKFBhcnRpdGlvbkRp c3BhdGNoRGF0YSkpOwogCQlwZFtpXS0+cmVsZGVzYyA9IHBhcnRyZWw7CkBA IC0xMDEwLDcgKzEwMTEsNyBAQCBSZWxhdGlvbkdldFBhcnRpdGlvbkRpc3Bh dGNoSW5mbyhSZWxhdGlvbiByZWwsIGludCBsb2NrbW9kZSwKIAkJcGRbaV0t PnBhcnRkZXNjID0gcGFydGRlc2M7CiAJCXBkW2ldLT5pbmRleGVzID0gKGlu dCAqKSBwYWxsb2MocGFydGRlc2MtPm5wYXJ0cyAqIHNpemVvZihpbnQpKTsK IAotCQltID0gMDsKKwkJbXlfcGFydGl0aW9uZWRfY2hpbGRyZW4gPSAwOwog CQlmb3IgKGogPSAwOyBqIDwgcGFydGRlc2MtPm5wYXJ0czsgaisrKQogCQl7 CiAJCQlPaWQJCQlwYXJ0cmVsaWQgPSBwYXJ0ZGVzYy0+b2lkc1tqXTsKQEAg LTEwMjYsMTEgKzEwMjcsMjEgQEAgUmVsYXRpb25HZXRQYXJ0aXRpb25EaXNw YXRjaEluZm8oUmVsYXRpb24gcmVsLCBpbnQgbG9ja21vZGUsCiAJCQkJICog V2UgY2FuIGFzc2lnbiBpbmRleGVzIHRoaXMgd2F5IGJlY2F1c2Ugb2YgdGhl IHdheQogCQkJCSAqIHBhcnRlZF9yZWxzIGhhcyBiZWVuIGdlbmVyYXRlZC4K IAkJCQkgKi8KLQkJCQlwZFtpXS0+aW5kZXhlc1tqXSA9IC0oaSArIDEgKyBt KTsKLQkJCQltKys7CisJCQkJcGRbaV0tPmluZGV4ZXNbal0gPSAtKDEgKwor CQkJCQkJCQkJICBteV9wYXJ0aXRpb25lZF9jaGlsZHJlbiArCisJCQkJCQkJ CQkgIHBhcnRpdGlvbmVkX2NoaWxkcmVuX3NvX2Zhcik7CisKKwkJCQlteV9w YXJ0aXRpb25lZF9jaGlsZHJlbisrOwogCQkJfQogCQl9CiAJCWkrKzsKKwor CQkvKgorCQkgKiBDaGlsZHJlbiBvZiB0aGlzIHBhcmVudCBzaG91bGQgYmUg cGxhY2VkIGFmdGVyIGFsbAorCQkgKiBwYXJ0aXRpb25lZCBjaGlsZHJlbiBv ZiBhbGwgcHJldmlvdXMgcGFyZW50cywgc28gd2UKKwkJICogaGF2ZSB0byB0 YWtlIHRoaXMgaW50byBhY2NvdW50LgorCQkgKi8KKwkJcGFydGl0aW9uZWRf Y2hpbGRyZW5fc29fZmFyICs9IG15X3BhcnRpdGlvbmVkX2NoaWxkcmVuOwog CX0KIAogCXJldHVybiBwZDsK --trojita=_ed660bf7-1094-4797-9d30-17a5ba0a6a31 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --trojita=_ed660bf7-1094-4797-9d30-17a5ba0a6a31--