public inbox for [email protected]
help / color / mirror / Atom feedFrom: Konstantin Knizhnik <[email protected]>
To: Zhihong Yu <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Konstantin Knizhnik <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: David Steele <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Jaime Casanova <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Ryan Lambert <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Dimitri Fontaine <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: Built-in connection pooler
Date: Mon, 22 Mar 2021 12:05:53 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALNJ-vSnRHYi2q5S7pA39eXNccba0Qk9DhL2J9_C-j1TC5TE3Q@mail.gmail.com>
References: <OSAPR01MB1985068ABB08A85828999460EA770@OSAPR01MB1985.jpnprd01.prod.outlook.com>
<[email protected]>
<OSAPR01MB1985554A600901FF0B8D125FEA710@OSAPR01MB1985.jpnprd01.prod.outlook.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CALNJ-vSnRHYi2q5S7pA39eXNccba0Qk9DhL2J9_C-j1TC5TE3Q@mail.gmail.com>
Hi,
Thank you for review!
On 21.03.2021 23:59, Zhihong Yu wrote:
> Hi,
>
> + With <literal>load-balancing</literal> policy postmaster
> choose proxy with lowest load average.
> + Load average of proxy is estimated by number of clients
> connection assigned to this proxy with extra weight for SSL connections.
>
> I think 'load-balanced' may be better than 'load-balancing'.
Sorry, I am not a native speaker.
But it seems to me (based on the articles I have read), then
"load-balancing" is more widely used term:
https://en.wikipedia.org/wiki/Load_balancing_(computing)
> postmaster choose proxy -> postmaster chooses proxy
Fixed.
>
> + Load average of proxy is estimated by number of clients
> connection assigned to this proxy with extra weight for SSL connections.
>
> I wonder if there would be a mixture of connections with and without SSL.
Why not? And what is wrong with it?
>
> + Terminate an idle connection pool worker after the specified
> number of milliseconds.
>
> Should the time unit be seconds ? It seems a worker would exist for at
> least a second.
>
Most of other similar timeouts: statement timeout, session timeout...
are specified in milliseconds.
> + * Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
>
> It would be better to update the year in the header.
Fixed.
>
> + * Use then for launching pooler worker backends and report error
>
> Not sure I understand the above sentence. Did you mean 'them' instead
> of 'then' ?
Sorry, it is really mistyping.
"them" should be used.
Fixed.
view thread (72+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Built-in connection pooler
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox