Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEJdC-0007FL-Vq for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 00:33:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pEJdA-0001qn-ID for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 00:33:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEJd9-0001kh-VA for pgsql-hackers@lists.postgresql.org; Sun, 08 Jan 2023 00:33:44 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEJd7-00029k-4l for pgsql-hackers@postgresql.org; Sun, 08 Jan 2023 00:33:42 +0000 Received: by mail-qt1-x82b.google.com with SMTP id x11so5119700qtv.13 for ; Sat, 07 Jan 2023 16:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1k8VOG8O5bZGZHXxU1+OfiG6sjciMI+bBluyDmlPLn4=; b=kkLq4KYEtx3TXJ3Rys/3dU5PGhtFglX9S30YmthYQG5DQgm1EJB0y6Tq1iPkdkU5AX V+aDJ4PZMpo3T3U1CyoIiDPfhlcF5LtXZLtWuYgD0OUTqNmdyuXRowq9vPqEpKHMzRq0 6x2Npy/Mu437G+pACVbiR9YDse3PWRF4gYx84DXcu6o+6xC7Px2k2RvBXOYbjBlpZ+67 7aNUmFm+Vtbysdo5v5PzzyJUCA/JKWY7E0wj5tD6xCsH/9Y11ZUG+yyADQ+rjz8Hyzse EUhssb1ccfrhX9GCMKnuAJ9OPy7IohLuOgGPebMe27NL0dPfysqHe7AGAFM6OVa1wIXf jz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1k8VOG8O5bZGZHXxU1+OfiG6sjciMI+bBluyDmlPLn4=; b=ph+8PpvuEAj8pFDNmR461vD4zU9Mn3LO79vmJqV+qqDYEU53ryfvTnks2OVGJInUkX nOgkLvQM0xrMQKfip7HQbhvsulf+ppNUXq9T4VKtgl+yNq4U28Rpbs3aZZL3Q1enM3il h9L8zPzs22vtGPGHCPvUEypwCLut5LQd1MR9X5UDQ7L8XrVIhFgfDch9XNuwax3Z7e5n Byy22tRnhcS123QQAiTWWqMYTwZMTS0cmF3i7yqQN+eiDihRZ80zT8g4bayfmbIPQW5N II2w43QpBtM2/ErWGsu+Ppn/e1RjQsJsDAmKG4DPJiXSqfsy0nc/hHKOB04G49crU75U wP7g== X-Gm-Message-State: AFqh2kpkyszPk8F/7iUoj8gnJbCOD4c6qi8Y60/8vaR9DE5F1Qhrf+Ce CIq4HqgAWIaVDd/AmaSBZ1JsUw== X-Google-Smtp-Source: AMrXdXvHQiQ4DC6QHU0qs5DLaxvQjVw+5pBLrB1HaYU6Y92UyqCV4lI/nSiI9P1kfIj2Mv7KPoDEbQ== X-Received: by 2002:a05:622a:488b:b0:3a9:9cbb:7cdf with SMTP id fc11-20020a05622a488b00b003a99cbb7cdfmr94284352qtb.40.1673138020171; Sat, 07 Jan 2023 16:33:40 -0800 (PST) Received: from [192.168.4.41] (162-239-31-113.lightspeed.dybhfl.sbcglobal.net. [162.239.31.113]) by smtp.gmail.com with ESMTPSA id h6-20020ac81386000000b003a7fef41526sm2507673qtj.77.2023.01.07.16.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jan 2023 16:33:39 -0800 (PST) Message-ID: <0e536d85-2b85-06a7-9051-be1bdf32852e@joeconway.com> Date: Sat, 7 Jan 2023 19:33:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: drop postmaster symlink To: Tom Lane , "Karl O. Pinc" Cc: Peter Eisentraut , Daniel Gustafsson , Robert Haas , Andres Freund , =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= , PostgreSQL Hackers References: <252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com> <6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org> <3705500.1669216069@sss.pgh.pa.us> <20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de> <20230107165942.748ccf4e@slate.karlpinc.com> <3492787.1673134705@sss.pgh.pa.us> Content-Language: en-US From: Joe Conway In-Reply-To: <3492787.1673134705@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 1/7/23 18:38, Tom Lane wrote: > "Karl O. Pinc" writes: >> This is a review of Peter's 2 patches. I see only 1 small problem. > >> Looking at the documentation, a "postmaster" in the glossary is >> defined as the controlling process. This works; it needs to be called >> something. There is still a postmaster.pid (etc.) in the data >> directory. > >> The word "postmaster" (case insensitive) shows up 84 times in the >> documentation. I looked at all of these. > > Hmm ... I thought this patch was about getting rid of the > admittedly-obsolete installed symlink. That was my understanding too. > If it's trying to get rid of the "postmaster" terminology for our > parent process, I'm very strongly against that, either as regards to > code or documentation. +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com