Content-Type: multipart/alternative;
 boundary="------------S6q50mC02qzJkE93q4ln0DNj"
Message-ID: <0e537c2a-0575-48c8-a9ac-78030f36a1ef@163.com>
Date: Thu, 16 Apr 2026 17:17:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw
To: "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM>
From: Yuchen Li <liyuchen_xyz@163.com>
In-Reply-To: 
 <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM>
Archived-At: 
 <https://www.postgresql.org/message-id/0e537c2a-0575-48c8-a9ac-78030f36a1ef%40163.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------S6q50mC02qzJkE93q4ln0DNj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/15/2026 5:27 PM, Daniel Westermann (DWE) wrote:
> Hi,
>
> while reading https://www.postgresql.org/docs/devel/postgres-fdw.html 
> <https://www.postgresql.org/docs/devel/postgres-fdw.html> I've noticed 
> that there is a single bracket on one line of the CREATE FOREIGN TABLE 
> example.
>
> Browsing through other docs (e,g. 
> https://www.postgresql.org/docs/devel/sql-createtable.html 
> <https://www.postgresql.org/docs/devel/sql-createtable.html> ) there 
> doesn't seem to be a rule for that but if there is a single bracket 
> (e.g. CREATE TABLE distributors), the options that follow usually 
> start at position one and are not indented (or they follow directly 
> after the bracket).
>
> The examples in file_fdw 
> (https://www.postgresql.org/docs/devel/file-fdw.html) follow a mix of 
> options which directly follow the bracket and on a new line.
>
> Attached a small patch which makes it looking a bit better, at least 
> in my opinion.
>
> Regards
> Daniel

While looking through the patch, I noticed a small formatting issue in
the following part:

+)
+SERVER foreign_server
+OPTIONS (schema_name 'some_schema', table_name 'some_table');

The added +) line appears to have a trailing space after the closing
parenthesis.

Regards,
Yuchen Li

--------------S6q50mC02qzJkE93q4ln0DNj
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 4/15/2026 5:27 PM, Daniel Westermann
      (DWE) wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        Hi,</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        <br>
      </div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        while reading <a
          href="https://www.postgresql.org/docs/devel/postgres-fdw.html"
          id="OWA74e68827-b1f3-d88e-7d45-3a2c01bbf15d"
          class="OWAAutoLink moz-txt-link-freetext"
          moz-do-not-send="true">
          https://www.postgresql.org/docs/devel/postgres-fdw.html</a> 
        I've noticed that there is a single bracket on one line of the
        CREATE FOREIGN TABLE example.</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        <br>
      </div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        Browsing through other docs (e,g. <a
href="https://www.postgresql.org/docs/devel/sql-createtable.html"
          id="OWA0be646c9-25a0-3b04-fe5d-156c9b4a2ac7"
          class="OWAAutoLink moz-txt-link-freetext"
          moz-do-not-send="true">
          https://www.postgresql.org/docs/devel/sql-createtable.html</a> )
        there doesn't seem to be a rule for that but if there is a
        single bracket (e.g. CREATE TABLE distributors), the options
        that follow usually start at position one and are not indented
        (or they follow directly after the bracket).</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        <br>
      </div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        The examples in file_fdw (<a
          href="https://www.postgresql.org/docs/devel/file-fdw.html"
          moz-do-not-send="true" class="moz-txt-link-freetext">https://www.postgresql.org/docs/devel/file-fdw.html</a>)
        follow a mix of options which directly follow the bracket and on
        a new line.</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        <br>
      </div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        Attached a small patch which makes it looking a bit better, at
        least in my opinion.</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        <br>
      </div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        Regards</div>
      <div class="elementToProof"
style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
        Daniel</div>
    </blockquote>
    <p>While looking through the patch, I noticed a small formatting
      issue in<br>
      the following part:<br>
      <br>
      +) <br>
      +SERVER foreign_server<br>
      +OPTIONS (schema_name 'some_schema', table_name 'some_table');<br>
      <br>
      The added +) line appears to have a trailing space after the
      closing<br>
      parenthesis.<br>
      <br>
      Regards,<br>
      Yuchen Li</p>
  </body>
</html>

--------------S6q50mC02qzJkE93q4ln0DNj--