public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Make all Perl warnings fatal
Date: Fri, 29 Dec 2023 20:27:31 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On 22.12.23 22:33, Peter Eisentraut wrote:
> On 12.09.23 07:42, Peter Eisentraut wrote:
>> On 10.08.23 07:58, Peter Eisentraut wrote:
>>> There are also a couple of issues in the MSVC legacy build system 
>>> that would need to be tightened up in order to survive with fatal 
>>> Perl warnings.  Obviously, there is a question whether it's worth 
>>> spending any time on that anymore.
>>
>> It looks like there are no principled objections to the overall idea 
>> here, but given this dependency on the MSVC build system removal, I'm 
>> going to set this patch to Returned with feedback for now.
> 
> Now that that is done, here is an updated patch for this.
> 
> I found one more bug in the Perl code because of this, a fix for which 
> is included here.
> 
> With this fix, this passes all the CI tests on all platforms.

committed

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Make all Perl warnings fatal
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox