Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfRrg-000CKe-8D for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 21:53:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rfRre-00FWGu-Lr for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 21:53:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfRre-00FWGl-Ck for pgsql-hackers@lists.postgresql.org; Wed, 28 Feb 2024 21:53:22 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfRrb-001uoO-0r for pgsql-hackers@postgresql.org; Wed, 28 Feb 2024 21:53:21 +0000 Received: from [10.5.0.2] (unknown [193.43.135.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 3A4AE54664 for ; Wed, 28 Feb 2024 21:53:18 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------h0WCXH4EWDMAw7EY6l9q5Ciq" Message-ID: <0e90da89-77ca-4ccf-872c-9626d755e288@pgmasters.net> Date: Thu, 29 Feb 2024 10:53:15 +1300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Pg Hackers From: David Steele Subject: Add checkpoint/redo LSNs to recovery errors. List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------h0WCXH4EWDMAw7EY6l9q5Ciq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hackers, This patch adds checkpoint/redo LSNs to recovery error messages where they may be useful for debugging. When backup_label is present the LSNs are already output in a log message, but it still seems like a good idea to repeat them. When backup_label is not present, the checkpoint LSN is not logged unless backup recovery is in progress or the checkpoint is found. In the case where a backup is restored but the backup_label is missing, the checkpoint LSN is not logged so it is useful for debugging to have it in the error message. Regards, -David --------------h0WCXH4EWDMAw7EY6l9q5Ciq Content-Type: text/plain; charset=UTF-8; name="add-lsn-to-err-v1.patch" Content-Disposition: attachment; filename="add-lsn-to-err-v1.patch" Content-Transfer-Encoding: base64 RnJvbSA5Njc4ZDBjZDkyOGM1OGU0YTNkMDM4YzhhYTRjMTkxZjViZGRkYmU3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBTdGVlbGUgPGRhdmlkQHBnbWFzdGVycy5u ZXQ+CkRhdGU6IFdlZCwgMjggRmViIDIwMjQgMjE6NDU6MzkgKzAwMDAKU3ViamVjdDogQWRk IGNoZWNrcG9pbnQvcmVkbyBMU05zIHRvIHJlY292ZXJ5IGVycm9ycy4KCldoZW4gYmFja3Vw X2xhYmVsIGlzIHByZXNlbnQgdGhlIExTTnMgYXJlIGFscmVhZHkgb3V0cHV0IGluIGEgbG9n IG1lc3NhZ2UsIGJ1dAppdCBzdGlsbCBzZWVtcyBsaWtlIGEgZ29vZCBpZGVhIHRvIHJlcGVh dCB0aGVtLgoKV2hlbiBiYWNrdXBfbGFiZWwgaXMgbm90IHByZXNlbnQsIHRoZSBjaGVja3Bv aW50IExTTiBpcyBub3QgbG9nZ2VkIHVubGVzcyBiYWNrdXAKcmVjb3ZlcnkgaXMgaW4gcHJv Z3Jlc3Mgb3IgdGhlIGNoZWNrcG9pbnQgaXMgZm91bmQuIEluIHRoZSBjYXNlIHdoZXJlIGEg YmFja3VwCmlzIHJlc3RvcmVkIGJ1dCB0aGUgYmFja3VwX2xhYmVsIGlzIG1pc3NpbmcsIHRo ZSBjaGVja3BvaW50IExTTiBpcyBub3QgbG9nZ2VkIHNvCml0IGlzIHVzZWZ1bCBmb3IgZGVi dWdnaW5nIHRvIGhhdmUgaXQgaW4gdGhlIGVycm9yIG1lc3NhZ2UuCi0tLQogc3JjL2JhY2tl bmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMgfCA5ICsrKysrKy0tLQogMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYyBiL3NyYy9iYWNr ZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVyeS5jCmluZGV4IGQ3M2E0OWIzZTguLmJh ZjE3NjVmNWUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dy ZWNvdmVyeS5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVy eS5jCkBAIC02NDcsNyArNjQ3LDggQEAgSW5pdFdhbFJlY292ZXJ5KENvbnRyb2xGaWxlRGF0 YSAqQ29udHJvbEZpbGUsIGJvb2wgKndhc1NodXRkb3duX3B0ciwKIAkJCQlpZiAoIVJlYWRS ZWNvcmQoeGxvZ3ByZWZldGNoZXIsIExPRywgZmFsc2UsCiAJCQkJCQkJCWNoZWNrUG9pbnQu VGhpc1RpbWVMaW5lSUQpKQogCQkJCQllcmVwb3J0KEZBVEFMLAotCQkJCQkJCShlcnJtc2co ImNvdWxkIG5vdCBmaW5kIHJlZG8gbG9jYXRpb24gcmVmZXJlbmNlZCBieSBjaGVja3BvaW50 IHJlY29yZCIpLAorCQkJCQkJCShlcnJtc2coImNvdWxkIG5vdCBmaW5kIHJlZG8gbG9jYXRp b24gJVgvJVggcmVmZXJlbmNlZCBieSBjaGVja3BvaW50IHJlY29yZCBhdCAlWC8lWCIsCisJ CQkJCQkJCQlMU05fRk9STUFUX0FSR1MoY2hlY2tQb2ludC5yZWRvKSwgTFNOX0ZPUk1BVF9B UkdTKENoZWNrUG9pbnRMb2MpKSwKIAkJCQkJCQkgZXJyaGludCgiSWYgeW91IGFyZSByZXN0 b3JpbmcgZnJvbSBhIGJhY2t1cCwgdG91Y2ggXCIlcy9yZWNvdmVyeS5zaWduYWxcIiBvciBc IiVzL3N0YW5kYnkuc2lnbmFsXCIgYW5kIGFkZCByZXF1aXJlZCByZWNvdmVyeSBvcHRpb25z LlxuIgogCQkJCQkJCQkJICJJZiB5b3UgYXJlIG5vdCByZXN0b3JpbmcgZnJvbSBhIGJhY2t1 cCwgdHJ5IHJlbW92aW5nIHRoZSBmaWxlIFwiJXMvYmFja3VwX2xhYmVsXCIuXG4iCiAJCQkJ CQkJCQkgIkJlIGNhcmVmdWw6IHJlbW92aW5nIFwiJXMvYmFja3VwX2xhYmVsXCIgd2lsbCBy ZXN1bHQgaW4gYSBjb3JydXB0IGNsdXN0ZXIgaWYgcmVzdG9yaW5nIGZyb20gYSBiYWNrdXAu IiwKQEAgLTY1Nyw3ICs2NTgsOCBAQCBJbml0V2FsUmVjb3ZlcnkoQ29udHJvbEZpbGVEYXRh ICpDb250cm9sRmlsZSwgYm9vbCAqd2FzU2h1dGRvd25fcHRyLAogCQllbHNlCiAJCXsKIAkJ CWVyZXBvcnQoRkFUQUwsCi0JCQkJCShlcnJtc2coImNvdWxkIG5vdCBsb2NhdGUgcmVxdWly ZWQgY2hlY2twb2ludCByZWNvcmQiKSwKKwkJCQkJKGVycm1zZygiY291bGQgbm90IGxvY2F0 ZSByZXF1aXJlZCBjaGVja3BvaW50IHJlY29yZCBhdCAlWC8lWCIsCisJCQkJCQkJTFNOX0ZP Uk1BVF9BUkdTKENoZWNrUG9pbnRMb2MpKSwKIAkJCQkJIGVycmhpbnQoIklmIHlvdSBhcmUg cmVzdG9yaW5nIGZyb20gYSBiYWNrdXAsIHRvdWNoIFwiJXMvcmVjb3Zlcnkuc2lnbmFsXCIg b3IgXCIlcy9zdGFuZGJ5LnNpZ25hbFwiIGFuZCBhZGQgcmVxdWlyZWQgcmVjb3Zlcnkgb3B0 aW9ucy5cbiIKIAkJCQkJCQkgIklmIHlvdSBhcmUgbm90IHJlc3RvcmluZyBmcm9tIGEgYmFj a3VwLCB0cnkgcmVtb3ZpbmcgdGhlIGZpbGUgXCIlcy9iYWNrdXBfbGFiZWxcIi5cbiIKIAkJ CQkJCQkgIkJlIGNhcmVmdWw6IHJlbW92aW5nIFwiJXMvYmFja3VwX2xhYmVsXCIgd2lsbCBy ZXN1bHQgaW4gYSBjb3JydXB0IGNsdXN0ZXIgaWYgcmVzdG9yaW5nIGZyb20gYSBiYWNrdXAu IiwKQEAgLTc5MSw3ICs3OTMsOCBAQCBJbml0V2FsUmVjb3ZlcnkoQ29udHJvbEZpbGVEYXRh ICpDb250cm9sRmlsZSwgYm9vbCAqd2FzU2h1dGRvd25fcHRyLAogCQkJICogc2ltcGxpZnkg cHJvY2Vzc2luZyBhcm91bmQgY2hlY2twb2ludHMuCiAJCQkgKi8KIAkJCWVyZXBvcnQoUEFO SUMsCi0JCQkJCShlcnJtc2coImNvdWxkIG5vdCBsb2NhdGUgYSB2YWxpZCBjaGVja3BvaW50 IHJlY29yZCIpKSk7CisJCQkJCShlcnJtc2coImNvdWxkIG5vdCBsb2NhdGUgYSB2YWxpZCBj aGVja3BvaW50IHJlY29yZCBhdCAlWC8lWCIsCisJCQkJCQkJTFNOX0ZPUk1BVF9BUkdTKENo ZWNrUG9pbnRMb2MpKSkpOwogCQl9CiAJCW1lbWNweSgmY2hlY2tQb2ludCwgWExvZ1JlY0dl dERhdGEoeGxvZ3JlYWRlciksIHNpemVvZihDaGVja1BvaW50KSk7CiAJCXdhc1NodXRkb3du ID0gKChyZWNvcmQtPnhsX2luZm8gJiB+WExSX0lORk9fTUFTSykgPT0gWExPR19DSEVDS1BP SU5UX1NIVVRET1dOKTsKLS0gCjIuMzQuMQoK --------------h0WCXH4EWDMAw7EY6l9q5Ciq--