Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q7Hcg-0003Hy-Jq
	for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Jun 2023 15:32:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q7Hce-0005IR-Fl
	for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Jun 2023 15:32:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1q7Hce-0005I7-6G
	for pgsql-hackers@lists.postgresql.org; Thu, 08 Jun 2023 15:32:24 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1q7Hca-0012u0-P8
	for pgsql-hackers@postgresql.org; Thu, 08 Jun 2023 15:32:23 +0000
Received: from [192.168.11.4] (p2361063-ipbf2222funabasi.chiba.ocn.ne.jp
 [114.177.59.63])
	by oss.nttdata.com (Postfix) with ESMTPSA id 6525460207;
	Fri,  9 Jun 2023 00:32:16 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com
Message-ID: <0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com>
Date: Fri, 9 Jun 2023 00:32:15 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: Allow pg_archivecleanup to remove backup history files
To: torikoshia <torikoshia@oss.nttdata.com>,
 Michael Paquier <michael@paquier.xyz>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 pgsql-hackers@postgresql.org
References: <ZEhIiaCa2rdc/SLb@paquier.xyz>
 <5adce8cd5ad2269fe687d2d56a341c88@oss.nttdata.com>
 <CALj2ACWq=axkHYKkWBAy5_DuuRGXDOhju_2EsexhxpWKZ-fiHg@mail.gmail.com>
 <61abc656edfba4a668b367d590b1aaab@oss.nttdata.com>
 <ZGF6WNGoVcUwi2EF@paquier.xyz>
 <e02ae6b16a32bdd2f4856e9b7f8a6439@oss.nttdata.com>
 <ZGHPsYohfCX+yRb6@paquier.xyz>
 <dea86e6f7224b41266b8a2bded766ca1@oss.nttdata.com>
 <ZG1nq13v411y4TFL@paquier.xyz>
 <0aad03237204efeb7038dafa38c202aa@oss.nttdata.com>
 <ZHBBarvyNq2FY82v@paquier.xyz>
 <be11e1f6f55854c3d5a818dfad819603@oss.nttdata.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <be11e1f6f55854c3d5a818dfad819603@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/0e962f8a-78f5-eafe-1d54-7434482e9fd1%40oss.nttdata.com>
Precedence: bulk



On 2023/05/31 10:51, torikoshia wrote:
> Update the patch according to the advice.

Thanks for updating the patches! I have small comments regarding 0002 patch.

+       <para>
+         Remove backup history files.

Isn't it better to document clearly which backup history files to be removed? For example, "In addition to removing WAL files, remove backup history files with prefixes logically preceding the oldestkeptwalfile.".


  	printf(_("  -n, --dry-run               dry run, show the names of the files that would be removed\n"));
+	printf(_("  -b, --clean-backup-history  clean up files including backup history files\n"));

Shouldn't -b option be placed in alphabetical order?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION