From: Grigorev Jurij <ju.grigorev@ftdata.ru>
To: Michael Paquier <michael@paquier.xyz>
CC: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized
 pgstats hash entry
Thread-Topic: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized
 pgstats hash entry
Thread-Index: 
 AQHdP268ccO9PMgx5Ei0J2uuaTqIjLbE5gWAgAEact2AC6lZAIAAD7eAgACbjC3//537gIAAg+33
Date: Thu, 17 Sep 2026 08:35:15 +0000
Message-ID: <0eb7233253374bce9f8ec0111a40b732@localhost.localdomain>
References: <ddc3ecfb01ce4e9698b23cc59767f016@localhost.localdomain>
 <aqCfwe5-EIiJXlIu@paquier.xyz>
 <a72c99d5b1e448b191a89e30ecaf3e8a@localhost.localdomain>
 <aqtU-qs5H3LbUum1@paquier.xyz> <aqtiKTvl519bu8-V@paquier.xyz>
 <d6ed296c81c14d03b1b5e283e913c40b@localhost.localdomain>,<aquSa2gbfVMxDYmT@paquier.xyz>
In-Reply-To: <aquSa2gbfVMxDYmT@paquier.xyz>
Accept-Language: ru-RU, en-US
Content-Language: ru-RU
Content-Type: text/plain; charset="koi8-r"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/0eb7233253374bce9f8ec0111a40b732%40localhost.localdomain>
Precedence: bulk

Agreed on all three points!

The two changes touch separate parts of pgstat_shmem.c, so the current
HEAD patch should apply cleanly on top of the defensive change.  I do
not expect any conflicts, but I will rebase and resend it if needed.

And yeah, regarding the ABI concern, even though pgstat_init_entry()
is declared in pgstat_internal.h and I found no external users, changing
its signature in stable branches does not seem worth the compatibility
risk.  I therefore agree that this patch should be limited to HEAD.

And agreed, no injection test for this narrow path!

Thanks,
  Yuriy=