Message-ID: <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
Date: Sun, 17 Apr 2022 10:56:08 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and
 recovery_end_comman
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org>
 <3385143.1649353230@sss.pgh.pa.us>
 <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
 <3386734.1649354265@sss.pgh.pa.us>
 <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
 <4015413.1649454951@sss.pgh.pa.us>
 <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
 <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
 <YlT23IvsXkGuLzFi@paquier.xyz>
 <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
 <YluU3C4i8sHoVeOQ@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <YluU3C4i8sHoVeOQ@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/0ec8e505-75ee-3426-78d9-9fd201c86f89%40dunslane.net>
Precedence: bulk


On 2022-04-17 Su 00:17, Michael Paquier wrote:
>> Since it's quite painful to run TAP tests under valgrind, I found a
>> place to stick a plain old sleep to repro these problems:
> Actually, I am wondering how you are patching Cluster.pm to do that.


I don't really think it's Cluster.pm's business to deal with that. It
takes an install path as given either explicitly or implicitly.

It shouldn't be too hard to get Makefile.global to install valgrind
wrappers into the tmp_install/bin directory.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com