Message-ID: <0f462532-9790-4334-b503-4ee522225820@iki.fi>
Date: Wed, 15 Apr 2026 19:51:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>, pgsql-hackers@postgresql.org
References: 
 <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: 
 <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/0f462532-9790-4334-b503-4ee522225820%40iki.fi>
Precedence: bulk

On 15/04/2026 16:57, Ayush Tiwari wrote:
> Hi,
> 
> The comment above the PM_STARTUP startup-process-failure case still says
> that there are no other processes running yet, so the postmaster can just
> exit.
> 
> That no longer matches the current startup flow: PM_STARTUP may already
> have auxiliary processes running by that point. The attached patch updates
> that comment to describe the current behavior.

Hmm, shouldn't the postmaster kill and wait for the auxiliary processes 
to exit first in that case? ISTM we need code changes here, not just 
comments.

- Heikki