Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wB2nA-000gSa-2s for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 03:44:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wB2n9-0093wa-0o for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 03:44:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wB2n8-0093wS-38 for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 03:44:23 +0000 Received: from mail-dy1-x1331.google.com ([2607:f8b0:4864:20::1331]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wB2n7-00000000GfL-449A for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 03:44:23 +0000 Received: by mail-dy1-x1331.google.com with SMTP id 5a478bee46e88-2b6b0500e06so2353465eec.1 for ; Thu, 09 Apr 2026 20:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20251104.gappssmtp.com; s=20251104; t=1775792661; x=1776397461; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ZBVPHmg2fcxKPN6ZZWD4y3p3C5T+FTXRq7VYpC+rgHA=; b=ETBxpXrZFe/SD9HMOKbeUnKmrA1A2sUSUf0M+JIhl6uYPf3R6y6OOFD1cUl5gXSW47 w97lbQBbqL+xzMvtHU59B8VQq6qKX/SmeIyuTsNtumN4mfUaxsvHtWF/7l8qaAbt2GAH arj0FaBSik/MANMpJiD8Wx1W5uaOIwyAyCASPc+paUb2kkcVche5zS3ZMZgqApUzWi9X t4TFUY/0grVE4waZBQAzu5rKxzWDd1xe3L3KPw8DGy5KiCzN/7qhI6t00ThfXCKXxJBB BnRpCCfqyNdhgBFDkeDnXoHs9024dcmZ57RSbq5ItgYpg+94QbfWkcdeVl+MnZrBkNJK hIMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775792661; x=1776397461; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZBVPHmg2fcxKPN6ZZWD4y3p3C5T+FTXRq7VYpC+rgHA=; b=glfvkr9h5KAIzj58WxsC7p3SI7gLlJiGF0zn/5riK/k3Qj6IuMGjHE4+ypCpNMlRom EaaJA4ZMNmJj0mp+cavUohmX7gJPxku4eM4bXDOB/x23Caj9cwtp2+lMZqJ0yXl1CH4n kFaEWUPHo2+HUeagssPLEgrViJgBFkl2igBAh2SZKuSq6V8oCE651qDjvdxSV7Go5YZQ CfIKojYIu34iwy6zsnZC2ApplZ6pqjgLE7Ipt4Z5q0PNzZK7FMZuwo7naM24KC18IOV2 AMfeqPuBHWaKkGaazduh7UaaEAlFS2w5ED3P7epFUYEezgZ8qYM3Ros5QMNnv06+dQDv CYvQ== X-Forwarded-Encrypted: i=1; AJvYcCUtf9C+Rj6dzjwj9ChbkkGrsV+Jh2S3d56VLaMjYeRfwcRiBZWtXpvpFQ9COMxMFpg3TuyZFnZ/zwxKQcqJ@lists.postgresql.org X-Gm-Message-State: AOJu0YwHTCJXJqL9pFYL5uwxKdoM2BwNYcIfp0dMdqUx5dlQ0CnYFgQv g0bV/2kaTXijuqaYeEGPuPCpoPlnW4wBbAR6FdpjAwadXOQXIl6vvh+6Er6gUWWTf15GDRHme7f qvz4= X-Gm-Gg: AeBDieusQd0p3rS1QDEiXtlP3Dq1DI5IjCe744CZmYwpwsOzML9AaW7DLO8cryaJOhk ei2PEkhUEljagdwziddl6rEvjTnV5ihhG5xiVO99xAj7rJyofyMqUfQ9T9oIq8w8FmWQAJvN/7d 6GpRpJ/8EGRjGed/FL0xi2dtKrG+xuilJyXdGkmKy7Mmxfk+O2vjioXDWBA0FTL7h1nvm63FM0b 2/3h76WRrdvsX/5RY5S9XbHELC11wFO8CBxlgwd+0rFs/fa0QxQ11jQXI6Hd3HjmGJf3JafWf5T b8HsccmM15zhUALh0fRB+6gyL3GB2k9kzQsxxWk3Zy1NIBowitoYtD4rcxFGORaVTWDGEsXNMM/ YRClo5jRp/YXGO7KJIXn2eIpm29PsijH2A92612IePLs0rY4lnDfV+qb67BZFIlY5NCtmhNNdST tWw/JIlruB1f8pcMMoLz/NN/bg5d55lmV+f5KesHdveIr1S+gvDvP7nMx2ZNX6Tg== X-Received: by 2002:a05:7301:608e:b0:2c1:6cfd:73ee with SMTP id 5a478bee46e88-2d589898d4cmr857517eec.24.1775792661275; Thu, 09 Apr 2026 20:44:21 -0700 (PDT) Received: from jeff-laptop.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d561bde70csm3093916eec.15.2026.04.09.20.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 20:44:20 -0700 (PDT) Message-ID: <0f4eb849fa443a07766b9d4f51d354b148580f2c.camel@j-davis.com> Subject: Re: Unused injection point in hash agg code From: Jeff Davis To: Daniel Gustafsson , PostgreSQL-development Date: Thu, 09 Apr 2026 20:44:19 -0700 In-Reply-To: <610A36DB-F413-41BF-9EB5-220D0CB09767@yesql.se> References: <610A36DB-F413-41BF-9EB5-220D0CB09767@yesql.se> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 2026-04-04 at 22:38 +0200, Daniel Gustafsson wrote: > Commit 38172d1856b3 introduced several injection points for hash > aggregation, > among them hash-aggregate-oversize-table which is never attached to > anywhere it > seems? >=20 > Should it be removed, or implemented in > injection_points/sql/hashagg.sql? Thank you. The tests could be expanded in that area. I'll look into that, and if it's not helpful, then I'll remove it. Regards, Jeff Davis