Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ta10I-00FGOH-UE for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2025 23:16:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ta10H-007vI8-Gb for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2025 23:16:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ta10H-007vI0-5s for pgsql-hackers@lists.postgresql.org; Mon, 20 Jan 2025 23:16:21 +0000 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ta10E-000cGL-0G for pgsql-hackers@lists.postgresql.org; Mon, 20 Jan 2025 23:16:20 +0000 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id DB81A114029A; Mon, 20 Jan 2025 18:16:16 -0500 (EST) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-01.internal (MEProxy); Mon, 20 Jan 2025 18:16:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1737414976; x=1737501376; bh=94t1UMyEfs tfZWZKMDNqxdo6W/I1PPTWlvet/x8HTNY=; b=bKdxFdufWB7Amwn/i2R7oqVFvY Z5lBGVm3rG34m/a7/wMIai1PhzGA0luNSpLWCtPazu2kJ8pihKAjEOT+Bty6+Kfj lCy8GrtZ2sQw5sFv830i0bNKLtVVdfRGXWnC1EpIS2xMS3UAfORs2oQDRnpCiuYY h0jQdDsAuvUKR9GIuzZdztS1cIzYmInajNjWnvRfZMgzlMPBd7c5krQLp0Q9nNyW MlTrpItwGcKRk2kmsgug+KJe7A9OM6X+Lp7IQjw40/IZbJzXoLCk1P3xd3h0WPyO gNPubv6m8fpAawYZzvzX0GmJilJ6G/OSbLjheOdy9iGzGZizqtLqtZOevMGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1737414976; x=1737501376; bh=94t1UMyEfstfZWZKMDNqxdo6W/I1PPTWlve t/x8HTNY=; b=cHrJMGuiNe12UuFFMJ5GB9LCba+ifp9+tGPqXn/+aSmM2nfOcZM Q9vj5hJd55SNYg6sEd8ZSYhcMSJn9HPhDMuelAjLvS7QjBub9H4JLP7Z0I0b+yQm zllVniGoAwC3CyFrWhBQ3dF/UGZTOAoxif0t7TwYoMqgRk5yA5Dxot+F6V8LOKVK /C2sm95uLRRLdgZGC0JAEIfIsMfuFRIrV6s82W9JEdutsei2UUz7zPWl6/57bOIb frAV2jPvuOo3IlWi1w941oDVRZHezUte8FyRpDoGL6WNZbPGZI6Ayzb9BreW34ji s6kZ275lrVwFplPktYjdp6G4hDc/adh3lLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudejtddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredttden ucfhrhhomhepfdfguhhlvghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrth hordgtohhmqeenucggtffrrghtthgvrhhnpeekheetvefggedtudevjeehjeffteeuvdfh fedtvdfgleektdfgfeektdfhheekvdenucffohhmrghinhepvghnthgvrhhprhhishgvug gsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepvghulhgvrhesvghulhgvrhhtohdrtghomhdpnhgspghrtghpthhtohepjedpmhhoug gvpehsmhhtphhouhhtpdhrtghpthhtohepphgvthgvrhesvghishgvnhhtrhgruhhtrdho rhhgpdhrtghpthhtohepvghulhgvrhdrthgrvhgvihhrrgesvghnthgvrhhprhhishgvug gsrdgtohhmpdhrtghpthhtohepshhmihhthhhpsgdvvdehtdesghhmrghilhdrtghomhdp rhgtphhtthhopehilhhmrghrihesihhlmhgrrhhirdhorhhgpdhrtghpthhtohepphhgsh hqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghp thhtohepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopehtghhlse hsshhsrdhpghhhrdhprgdruhhs X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 31C71780068; Mon, 20 Jan 2025 18:16:15 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Mon, 20 Jan 2025 20:15:54 -0300 From: "Euler Taveira" To: "Tom Lane" Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= , "Peter Smith" , "Michael Paquier" , "PostgreSQL Hackers" , "Peter Eisentraut" , "Euler Taveira" Message-Id: <0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com> In-Reply-To: <3238498.1737413396@sss.pgh.pa.us> References: <556792.1733967676@sss.pgh.pa.us> <564915.1733971586@sss.pgh.pa.us> <87pllx5cqn.fsf@wibble.ilmari.org> <87msh159c3.fsf@wibble.ilmari.org> <87o70143p6.fsf@wibble.ilmari.org> <3b6b2595-9822-4e4f-91ee-b6a44dc4b542@app.fastmail.com> <3238498.1737413396@sss.pgh.pa.us> Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read. Content-Type: multipart/alternative; boundary=cc7b673536b0424f963b90280f969bb8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --cc7b673536b0424f963b90280f969bb8 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Jan 20, 2025, at 7:49 PM, Tom Lane wrote: > "Euler Taveira" writes: > > It is kind of annoying to keep version 20230309 around to run perltidy. Do we > > have any other alternatives? > > As it says in src/tools/pgindent/README: > > 2) Install perltidy. Please be sure it is version 20230309 (older and newer > versions make different formatting choices, and we want consistency). > > I don't think anyone is especially wedded to 20230309 in particular, > but we don't want different developers using different versions and > coming out with different results. The whole point of this effort > is to standardize code layout as best we can, so that would be > counterproductive. I can live with that. > Do you have a strong argument for switching to some other specific > version of perltidy? > I don't. Let's see if the Dagfinn's patch will maintain more stable formatting over the years. I tested in a previous version (20220613) after applying the patch and it didn't suggest changes. -- Euler Taveira EDB https://www.enterprisedb.com/ --cc7b673536b0424f963b90280f969bb8 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Mon, Jan 20,= 2025, at 7:49 PM, Tom Lane wrote:
"Euler Taveira" <euler@eulerto.com> writes:
> It is kind= of annoying to keep version 20230309 around to run perltidy. Do we
<= /div>
> have any other alternatives?

As it says in src/tools/pgindent/README:

2= ) Install perltidy.  Please be sure it is version 20230309 (older a= nd newer
   versions make different formatting c= hoices, and we want consistency).

I don't t= hink anyone is especially wedded to 20230309 in particular,
but we don't want different developers using different versions and
coming out with different results.  The whole point of = this effort
is to standardize code layout as best we can, = so that would be
counterproductive.
=

I can live with that.

Do you have a strong argum= ent for switching to some other specific
version of perlti= dy?


I don't. Le= t's see if the Dagfinn's patch will maintain more stable formatting
<= /div>
over the years. I tested in a previous version (20220613) afte= r applying the
patch= and it didn't suggest changes.


--
Euler Taveira
EDB&nb= sp;  https://www.enterpri= sedb.com/

--cc7b673536b0424f963b90280f969bb8--