Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeTc0-00006E-SI for pgsql-hackers@arkaria.postgresql.org; Fri, 29 May 2020 01:15:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jeTby-0004Fs-Hq for pgsql-hackers@arkaria.postgresql.org; Fri, 29 May 2020 01:15:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeTby-0004Fl-BF for pgsql-hackers@lists.postgresql.org; Fri, 29 May 2020 01:15:02 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jeTbw-0008Td-FI for pgsql-hackers@postgresql.org; Fri, 29 May 2020 01:15:01 +0000 Received: by mail-pg1-x532.google.com with SMTP id s10so507285pgm.0 for ; Thu, 28 May 2020 18:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=RU9LBgc5uMgNNGjLvhv0BAbzDO9GXk0rION8mquYnr0=; b=0B3oNVsHwZnFpd65dBUslMr5WLE4PaRlJVrLK62KbqigrZeqJ5hFif9meVzYtnkJyL hsxLooN6Won1NtFV2kmoFqr/wP48FkMsFXiN+fJ0KHaE9XE1hsNogkbQiC2M+eaO79Uq TeMmJb93UEaOAYHWP0ZlBhcMLNmaiWsy4npVn2j3r2A/3TIOnKTji7HSv2+FPbeD1BeC R22wL+OXyhkmPZLM6inIodw+TPDmRfkVtBvsaU7Z5eu14WsXmJdZlCZUn0Ecdf0Dkcdf z7Hw2IsK9LA8ROKRs7o0oc7QWl5Tx26RpnHexRXSEXynZwXdDKpGqCxfrV29afj10jYz vRsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=RU9LBgc5uMgNNGjLvhv0BAbzDO9GXk0rION8mquYnr0=; b=KWj9x2vnSkDFsB/C9ZXxn5+6D9iYhWsZZH0sR5U4bQqhfPrE6l5xdT+wwOgIFPTAQc CrVLJIcYoB732rjSq65SbczPvzOH80CvfWwuwPhcsjr3gqkpWg1r6iPvWKzf/GgrR6ek /4kf+sB70YfVmZY+PggeyT52TG6hS95upy5yh8uQqte3nxZCDrfmizPjyhnIOFukpkm3 CiZgthFN6fnEBUf3pXlMvONvu21HgtI4rbfNJTw8jRDZ9kYFUOr+cAn5TrB/E/9h8uo2 /c9sUu+bY6SAU1+ux9JgSTrVcoke5E1G4x9LT+h+cKkGMy5JC26Yo0zkQi1NKMw9lLKJ s2kA== X-Gm-Message-State: AOAM531GGrhTeOcB9J1NCKh/2Gw+leALFxQsDltvp/3hUYe73+u2SaMk 77AOdQmRkfys5t/k+SGzAb1uWg== X-Google-Smtp-Source: ABdhPJyCM4xqpp+N59tBDtaMpKfbaUi5ELz1Ts3HvPC5YBdg3qCJ4FMn9svMpBFtdiISGsTrHpruPQ== X-Received: by 2002:a63:d547:: with SMTP id v7mr5788785pgi.413.1590714898287; Thu, 28 May 2020 18:14:58 -0700 (PDT) Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id v13sm4300308pff.27.2020.05.28.18.14.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 May 2020 18:14:57 -0700 (PDT) Message-ID: <0fb3456095d469cc20a9ee7e76edfe9237dae24f.camel@j-davis.com> Subject: Re: Trouble with hashagg spill I/O pattern and costing From: Jeff Davis To: Tomas Vondra , Melanie Plageman Cc: Thomas Munro , pgsql-hackers , HeikkiLinnakangas Date: Thu, 28 May 2020 18:14:55 -0700 In-Reply-To: <20200528185750.aamptuqdzrggqi5c@development> References: <20200525121722.6wzcelweefyuwg54@development> <2df2e0728d48f498b9d6954b5f9080a34535c385.camel@j-davis.com> <20200525225909.aifxjm53hw4xyzxd@development> <20200526141524.ohtvrp23vxosgivl@development> <20200526191511.d7pwz4awrvdm4p6j@development> <0589f869969de2f3e9713689159c7c4fbe1fcfa5.camel@j-davis.com> <20200527090704.onkjogxeg34ib5cn@development> <20200528185750.aamptuqdzrggqi5c@development> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, 2020-05-28 at 20:57 +0200, Tomas Vondra wrote: > Attached is a patch adding CP_SMALL_TLIST to create_agg_plan and > create_groupingsets_plan. Looks good, except one question: Why would aggstrategy ever be MIXED when in create_agg_path? Wouldn't that only happen in create_groupingsets_path? Regards, Jeff Davis